+/* Tell compiler that status_blk fields can change. */
+barrier();
+if (status_idx != sblk-status_idx) {
Is a compiler barrier sufficient here? It seems an out-of-order CPU
could still mess things up, so an rmb() or smp_rmb() would be required.
+config CNIC
+tristate Broadcom CNIC support
+depends on BNX2
I suspect you'll need a depends on INET somewhere (probably here, but
maybe only for the iSCSI part).
- R.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to
On Fri, 2008-05-23 at 13:14 -0700, Roland Dreier wrote:
+ /* Tell compiler that status_blk fields can change. */
+ barrier();
+ if (status_idx != sblk-status_idx) {
Is a compiler barrier sufficient here? It seems an out-of-order CPU
could still mess things
On Thu, 2008-05-22 at 00:44 -0700, Paul E. McKenney wrote:
+
+int cnic_register_driver(int ulp_type, struct cnic_ulp_ops *ulp_ops)
+{
+ struct cnic_dev *dev;
+
+ if (ulp_type = MAX_CNIC_ULP_TYPE) {
+ printk(KERN_ERR PFX cnic_register_driver: Bad type %d\n,
+
