Re: [PATCH v2] SCSI: libiscsi: fix NOP race condition

2020-11-11 Thread Mike Christie
On 11/6/20 1:33 PM, Lee Duncan wrote: From: Lee Duncan iSCSI NOPs are sometimes "lost", mistakenly sent to the user-land iscsid daemon instead of handled in the kernel, as they should be, resulting in a message from the daemon like: iscsid: Got nop in, but kernel supports nop handling.

Antw: [EXT] [PATCH v2] SCSI: libiscsi: fix NOP race condition

2020-11-08 Thread Ulrich Windl
>>> Lee Duncan schrieb am 06.11.2020 um 20:33 in Nachricht <20201106193317.16993-1-leeman.dun...@gmail.com>: ... > +/* invalid scsi_task pointer */ > +#define INVALID_SCSI_TASK (struct iscsi_task *)-1l ... Comment: I prefer 'L' over 'l', because in many fonts 'I', '1' and 'l' look

[PATCH v2] SCSI: libiscsi: fix NOP race condition

2020-11-06 Thread Lee Duncan
From: Lee Duncan iSCSI NOPs are sometimes "lost", mistakenly sent to the user-land iscsid daemon instead of handled in the kernel, as they should be, resulting in a message from the daemon like: > iscsid: Got nop in, but kernel supports nop handling. This can occur because of the new forward-