Antw: [PATCH] iscsi tools: Convert '-r' argument to an integer before checking if it is a path

2012-10-22 Thread Ulrich Windl
Jim Ramsay jim_ram...@dell.com schrieb am 03.10.2012 um 15:57 in Nachricht 1349272663-18322-1-git-send-email-jim_ram...@dell.com: If there is a file in the CWD named '1' and you were trying to run 'iscsiadm -m session -r 1 ...', the command would fail with 1 is not a directory. Root cause:

[PATCH 0/4] ISCSITOOLS: Patchset to add the extraction of ibft net attributes

2012-10-22 Thread Eddie Wai
For the case when iscsid is invoked for the first time after pivot root during iSCSI boot, the boot connection would fail to re-connect if the ibft/iscsi_boot sysfs entry contains tagged vlan. The problem was caused by the lack of such info in the iscsi_session sysfs for sync_session to inherit

[PATCH 3/4] ISCSID: Added the extraction of the session boot_nic info

2012-10-22 Thread Eddie Wai
This patch does the work to extract the corresponding ibft-ethernetN net params as specified from the kernel session boot_nic sysfs entry. Signed-off-by: Eddie Wai eddie@broadcom.com --- include/iscsi_if.h |3 +++ usr/iscsi_sysfs.c | 25 - 2 files changed, 27

[PATCH 2/4] LIBISCSI: Added boot_nic session sysfs

2012-10-22 Thread Eddie Wai
Kernel component to enable the new 'boot_nic' param in the kernel session sysfs. Signed-off-by: Eddie Wai eddie@broadcom.com --- kernel/libiscsi.c |6 ++ kernel/libiscsi.h |2 ++ kernel/scsi_transport_iscsi.c |2 ++ 3 files changed, 10 insertions(+),

Re: [PATCH 2/4] LIBISCSI: Added boot_nic session sysfs

2012-10-22 Thread Mike Christie
On 10/22/2012 05:13 PM, Eddie Wai wrote: Kernel component to enable the new 'boot_nic' param in the kernel session sysfs. Signed-off-by: Eddie Wai eddie@broadcom.com --- kernel/libiscsi.c |6 ++ kernel/libiscsi.h |2 ++

Re: [PATCH 0/4] ISCSITOOLS: Patchset to add the extraction of ibft net attributes

2012-10-22 Thread Mike Christie
Could you post the patch that sets the boot nic value on the session? On 10/22/2012 05:13 PM, Eddie Wai wrote: For the case when iscsid is invoked for the first time after pivot root during iSCSI boot, the boot connection would fail to re-connect if the ibft/iscsi_boot sysfs entry contains

Re: [PATCH 0/4] ISCSITOOLS: Patchset to add the extraction of ibft net attributes

2012-10-22 Thread Mike Christie
On 10/22/2012 05:21 PM, Mike Christie wrote: Could you post the patch that sets the boot nic value on the session? Ignore this. I see it. I was thinking you were having the kernel/driver set it. -- You received this message because you are subscribed to the Google Groups open-iscsi group. To

[PATCH] LIBISCSI: Added the new boot_nic entry in the session sysfs

2012-10-22 Thread Eddie Wai
This is the kernel part of the modification to extract the net params from the ibft sysfs to the iface struct used for the connection request upon sync_session in the open-iscsi util. Signed-off-by: Eddie Wai eddie@broadcom.com --- drivers/scsi/libiscsi.c |6 ++