[PATH 0 of 1] Fix check for nice() return value
I mentioned this before, but I didn't have a good solution at the time. In usr/iscsi_util.c, nice() is called like this: if (nice(-10) 0) log_debug(...) The problem is that nice() returns the current nice value, and that value can legitimately be less than zero, in which case a spurious log message is generated. Although I don't like setting errno directly except when in a library, the nice(2) man page actually suggests this as the best way to fix the problem. Therefore, the supplied patch is designed to fix this problem. -- Ignore the Lee-Man behind the curtain ... Life's a long song. But the tune ends too soon for us all. -- Ian Anderson -- You received this message because you are subscribed to the Google Groups open-iscsi group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
PATCH 1 of 1] correctly check return value of nice()
The nice() call can return a negative value, since it returns the previous nice value. Signed-off-by: Lee Duncan leeman.dun...@gmail.com --- usr/iscsi_util.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/usr/iscsi_util.c b/usr/iscsi_util.c index 5e3420e..ac86847 100644 --- a/usr/iscsi_util.c +++ b/usr/iscsi_util.c @@ -60,7 +60,8 @@ int oom_adjust(void) char path[ISCSI_OOM_PATH_LEN]; struct stat statb; - if (nice(-10) 0) + errno = 0; + if (nice(-10) == -1 errno != 0) log_debug(1, Could not increase process priority: %s, strerror(errno)); -- 1.7.10.4 -- You received this message because you are subscribed to the Google Groups open-iscsi group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: [PATH 0 of 1] Fix check for nice() return value
Apologies for Subject formatting errors ... I need to wean myself off of OS X ... On Tuesday, May 21, 2013 2:15:00 PM UTC-7, The Lee-Man wrote: I mentioned this before, but I didn't have a good solution at the time. In usr/iscsi_util.c, nice() is called like this: if (nice(-10) 0) log_debug(...) The problem is that nice() returns the current nice value, and that value can legitimately be less than zero, in which case a spurious log message is generated. Although I don't like setting errno directly except when in a library, the nice(2) man page actually suggests this as the best way to fix the problem. Therefore, the supplied patch is designed to fix this problem. -- Ignore the Lee-Man behind the curtain ... Life's a long song. But the tune ends too soon for us all. -- Ian Anderson -- You received this message because you are subscribed to the Google Groups open-iscsi group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
