Hi!
While most of your changes seem reasonable, this one (if ACTOR_MAX_LOOPS will
ever be different from 1) may be discussable. One rule of software negineering
says: never use a literal constant (except when defining a symbolic one ;-)
Regards,
Ulrich
Chris Leech cle...@redhat.com schrieb
Chris Leech cle...@redhat.com schrieb am 12.06.2013 um 07:24 in Nachricht
1371014686-22334-8-git-send-email-cle...@redhat.com:
[...]
diff --git a/usr/event_poll.c b/usr/event_poll.c
index f36fec1..dcbb79a 100644
--- a/usr/event_poll.c
+++ b/usr/event_poll.c
@@ -121,17 +121,37 @@ static int
On 11/06/2013 20:18, Mike Christie wrote:
On 6/9/13 9:54 AM, Or Gerlitz wrote:
usr]# make
Hey,
Did you figure this out?
Support for that changed. You need to do make from the top level dir,
because of dependencies on other stuff. Once that stuff is built you
can do make from the usr dir
Hi!
I wonder: Isn't -static quite obsolete? If not, are you sure you installed
the static C libraries?
Regards,
Ulrich
Or Gerlitz ogerl...@mellanox.com schrieb am 12.06.2013 um 09:31 in
Nachricht
51b823e6.5090...@mellanox.com:
On 11/06/2013 20:18, Mike Christie wrote:
On 6/9/13 9:54 AM,
On 12/06/2013 10:53, Ulrich Windl wrote:
are you sure you installed the static C libraries?
this might be the problem, I wasn't sure what rpm/s I need to install
for that.
--
You received this message because you are subscribed to the Google Groups
open-iscsi group.
To unsubscribe from
On Wed, Jun 12, 2013 at 08:31:09AM +0200, Ulrich Windl wrote:
Hi!
While most of your changes seem reasonable, this one (if
ACTOR_MAX_LOOPS will ever be different from 1) may be discussable. One
rule of software negineering says: never use a literal constant
(except when defining a symbolic
On 06/12/2013 12:24 AM, Chris Leech wrote:
iscsid doesn't need to wake up every 250ms, we can drive the polling of the
actor callbacks only when they are needed.
Passing on the prep patches as they were sent to me by Adam Jackson, but I've
reworked the final event loop changes to keep the
On 06/12/2013 12:24 AM, Chris Leech wrote:
iscsid doesn't need to wake up every 250ms, we can drive the polling of the
actor callbacks only when they are needed.
Passing on the prep patches as they were sent to me by Adam Jackson, but I've
reworked the final event loop changes to keep the
On Wed, Jun 12, 2013 at 10:55:01AM -0500, Mike Christie wrote:
On 06/12/2013 12:24 AM, Chris Leech wrote:
iscsid doesn't need to wake up every 250ms, we can drive the polling of the
actor callbacks only when they are needed.
Passing on the prep patches as they were sent to me by Adam
