Do you prefer pull requests or patches submitted?

2016-01-15 Thread The Lee-Man
Hi Mike: I see you have taken some pull requests using the github issue/pull-request mechanism. Do you prefer this over the mailing list? I know I kind of prefer it, myself, from both directions, since it makes the workflow a touch easier and faster. What's your preference? -- Lee Duncan --

Re: Do you prefer pull requests or patches submitted?

2016-01-15 Thread Michael Christie
> On Jan 15, 2016, at 1:49 PM, The Lee-Man wrote: > > Hi Mike: > > I see you have taken some pull requests using the github issue/pull-request > mechanism. Do you prefer this over the mailing list? I know I kind of prefer > it, myself, from both directions, since it

[PATCH 3/3] iscsiuio: fixup race condition

2016-01-15 Thread Lee Duncan
From: Hannes Reinecke valgrind detected a race condition in the nic receive loop. Signed-off-by: Hannes Reinecke Acked-by: Lee Duncan --- iscsiuio/src/unix/nic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 0/3] Fix Valgrind Issues in iscsiuio

2016-01-15 Thread Lee Duncan
Hannes recently fixed some valgrind issues in iscsiuio, but they seem to have fallen between the cracks, so here they are. Hannes Reinecke (3): iscsiuio: Do not memcpy identical locations iscsiuio: Clear memory after allocation iscsiuio: fixup race condition iscsiuio/src/uip/uip.c

[PATCH 1/3] iscsiuio: Do not memcpy identical locations

2016-01-15 Thread Lee Duncan
From: Hannes Reinecke It's pretty much pointless do a memcpy with src and dst identical. Found by valgrind. Signed-off-by: Hannes Reinecke Acked-by: Lee Duncan --- iscsiuio/src/uip/uip.c | 12 iscsiuio/src/unix/nic.c | 16