Re: [PATCH] scsi:libiscsi:Fix an error count for active session
wubo, > Fix an error count for active session if the total_cmds is invalid on > the function iscsi_session_setup(). decrement the number of active > sessions before the func return. Applied to 5.7/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/open-iscsi/yq1tv2acy00.fsf%40oracle.com.
Re: [PATCH RESEND v4] iscsi: Report connection state on sysfs
Gabriel, > If an iSCSI connection happens to fail while the daemon isn't running > (due to a crash or for another reason), the kernel failure report is > not received. When the daemon restarts, there is insufficient kernel > state in sysfs for it to know that this happened. open-iscsi tries to > reopen every connection, but on different initiators, we'd like to > know which connections have failed. Applied to 5.7/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/open-iscsi/yq1369uftfo.fsf%40oracle.com.
Re: [PATCH] scsi:libiscsi:Fix an error count for active session
On 3/24/20 11:53 PM, wubo (T) wrote: > From: Wu Bo > > Fix an error count for active session if the total_cmds is invalid > on the function iscsi_session_setup(). > decrement the number of active sessions before the func return. > > Signed-off-by: Wu Bo > --- > drivers/scsi/libiscsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c > index 70b99c0..b7158eb 100644 > --- a/drivers/scsi/libiscsi.c > +++ b/drivers/scsi/libiscsi.c > @@ -2771,7 +2771,7 @@ struct iscsi_cls_session * >"must be a power of 2.\n", total_cmds); > total_cmds = rounddown_pow_of_two(total_cmds); > if (total_cmds < ISCSI_TOTAL_CMDS_MIN) > - return NULL; > + goto dec_session_count; > printk(KERN_INFO "iscsi: Rounding can_queue to %d.\n", >total_cmds); > } > -- > 1.8.3.1 > Reviewed-by: Lee Duncan -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/open-iscsi/d4f7d5e1-1695-488e-2fee-ab562173d079%40suse.com.
Re: replacement_timeout Override
I'm glad you figured it out. Sorry I didn't reply sooner. On Monday, March 16, 2020 at 9:40:53 PM UTC-7, Marc Smith wrote: > > On Sat, Mar 14, 2020 at 10:28 AM Marc Smith wrote: > > > > Hi, > > > > I'm using open-iscsi version 2.1.1. I noticed that my > > "replacement_timeout" value set in the node record is not being > > applied, or rather is not overriding the default value set in > > iscsid.conf: > > > > # iscsiadm -m node -T internal_redirect | grep replacement_timeout > > node.session.timeo.replacement_timeout = 5 > > > > # cat /etc/iscsi/iscsid.conf | grep replacement_timeout > > node.session.timeo.replacement_timeout = 120 > > > > # cat /sys/class/iscsi_session/session1/recovery_tmo > > 120 > > > > # iscsiadm -m session -P 2 | grep Recovery > > Recovery Timeout: 120 > > > > I can certainly change this value in iscsid.conf, but I was thinking > > my value in the node record would override this (for this specific > > target). Is it expected that this value should override what's in > > iscsid.conf? If so, then I assume I've hit a bug, or perhaps I have > > something configured incorrectly? > > Okay, so after digging a bit, the default values from iscsid.conf are > in fact being superseded by the specific session values. That is > demonstrated when I run "iscsiadm -m node -T internal_redirect". The > only problem is the values aren't applied to the running session (the > sysfs attribute files for the session are not updated when the record > is updated). > > I was changing the values for a session that was already established. > The solution is to set the node record values, then simply logout and > login. > > --Marc > > > > > > Thanks for your time. > > > > --Marc > -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/open-iscsi/62df8000-a715-4658-b36d-cf5552a9c766%40googlegroups.com.
Re: There are two same sessions on the on client node? what's happen with it?
Those are two different sessions, as distinguished by their session numbers. On Thursday, March 5, 2020 at 7:42:46 PM UTC-8, can zhu wrote: > > [image: 微信图片_20200306114227.png] > > -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/open-iscsi/503795d3-3b41-48ef-9945-4de6ff83e605%40googlegroups.com.
