[PATCH] open-iscsi-ldflags.patch
Hi, attached you will find a patch for the Makefile to respect LDFLAGS. It would be nice to see it in the next release, thanks! diff --git a/usr/Makefile b/usr/Makefile index 3ee0cb4..5e3128a 100644 --- a/usr/Makefile +++ b/usr/Makefile @@ -30,7 +30,7 @@ DCB_OBJ= endif endif -OPTFLAGS ?= -O2 -g +OPTFLAGS ?= -O2 -g $(LDFLAGS) WARNFLAGS ?= -Wall -Wstrict-prototypes CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../include -I. -I../utils/open- isns \ -D$(OSNAME) $(IPC_CFLAGS) diff --git a/utils/Makefile b/utils/Makefile index 2c7e891..e88265c 100644 --- a/utils/Makefile +++ b/utils/Makefile @@ -1,6 +1,6 @@ # This Makefile will work only with GNU make. -CFLAGS += $(OPTFLAGS) -O2 -fno-inline -Wall -Wstrict-prototypes -g +CFLAGS += $(OPTFLAGS) $(LDFLAGS) -O2 -fno-inline -Wall -Wstrict- prototypes -g PROGRAMS = iscsi-iname all: $(PROGRAMS) diff --git a/utils/fwparam_ibft/Makefile b/utils/fwparam_ibft/Makefile index ca07b76..64823e4 100644 --- a/utils/fwparam_ibft/Makefile +++ b/utils/fwparam_ibft/Makefile @@ -26,7 +26,7 @@ OBJS := fw_entry.o fwparam_sysfs.o $ (SYSDEPS_OBJS) ../../usr/iscsi_net_util.o OBJS += prom_lex.o prom_parse.tab.o fwparam_ppc.o CLEANFILES = $(OBJS) *.output *~ -OPTFLAGS ?= -O2 -g -fPIC +OPTFLAGS ?= -O2 -g -fPIC $(LDFLAGS) WARNFLAGS ?= -Wall -Wstrict-prototypes CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../../include -I../../usr -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: PowerVault MD3200i/MD3220i
On 26 Aug., 12:46, swejis jo...@wehay.com wrote: Greetings. Considering buying a PowerVault MD3200i/MD3220i. Anyone here using that target with open-iscsi ? And if so what is your experience ? Yes, I own such a box. I hate it a bit. Why? - rather low pricing, but lots of anti-features: no snapshots, no virtual disk copy, no performance tier (yea, they really slow down the box intentionally and you have to buy for releasing the brake). Pay about 4k€ extra to have a working SAN. - only 10K SAS disks available for 2,5 - Bad connectivity: 4x 1GE only, 8x1GE possible, but only one storage controller can be active AFAIR; if you have 24 SAS disks in there, it's a bad bottleneck IMHO - I dislike the many multipaths, two times 10GE would really be nicer - only one iscsi target. You have to do funny lun rescanning all the time, which is doable, but if you don't take very good care when removing the iscsi LUNs and if it's still in use by multipath, it can crash your complete box (still analyzing why); also you cannot have two iscsi targets for two network zones (production/testing) for better separation - bad performance, the local 2,5 SAS 15k disk brings twice the performance the SAN. Still searching why, maybe I'm writing something about that later. - I really hate the windows interface, an integrated webserver would've been nicer (that's personal taste only, and yes, there is still the CLI) I'm still in the process of setting this up, but I don't like this box at all. I'd really like to test an Equallogic as replacement but Dell (or rather our reseller) doesn't seem to be willing to take exchange, even if we buy a much bigger equallogic. Best regards, Craig -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: Antw: [PATCH] open-iscsi-ldflags.patch
While patching it: Shouldn't -O2 -fno-inline be part of $(OPTFLAGS)? Ulrich I guess so - here is the patch with fixed OPTFLAGS, it's ok for merging now. :) Best regardsm Craig diff --git a/usr/Makefile b/usr/Makefile index 3ee0cb4..dcf78c2 100644 --- a/usr/Makefile +++ b/usr/Makefile @@ -30,7 +30,7 @@ DCB_OBJ= endif endif -OPTFLAGS ?= -O2 -g +OPTFLAGS ?= -O2 -g -fno-inline $(LDFLAGS) WARNFLAGS ?= -Wall -Wstrict-prototypes CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../include -I. -I../utils/open- isns \ -D$(OSNAME) $(IPC_CFLAGS) diff --git a/utils/Makefile b/utils/Makefile index 2c7e891..42c36ce 100644 --- a/utils/Makefile +++ b/utils/Makefile @@ -1,6 +1,6 @@ # This Makefile will work only with GNU make. -CFLAGS += $(OPTFLAGS) -O2 -fno-inline -Wall -Wstrict-prototypes -g +CFLAGS += $(OPTFLAGS) $(LDFLAGS) -Wall -Wstrict-prototypes -g PROGRAMS = iscsi-iname all: $(PROGRAMS) diff --git a/utils/fwparam_ibft/Makefile b/utils/fwparam_ibft/Makefile index ca07b76..9276722 100644 --- a/utils/fwparam_ibft/Makefile +++ b/utils/fwparam_ibft/Makefile @@ -28,7 +28,7 @@ CLEANFILES = $(OBJS) *.output *~ OPTFLAGS ?= -O2 -g -fPIC WARNFLAGS ?= -Wall -Wstrict-prototypes -CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../../include -I../../usr +CFLAGS += $(OPTFLAGS) $(LDFLAGS) $(WARNFLAGS) -I../../include -I../../ usr all: $(OBJS) -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: open-iscsi-overflow-search-ibft
Hi,
your patch did not apply, I patched it against the current git tree:
--- a/utils/fwparam_ibft/fwparam_ibft.c
+++ b/utils/fwparam_ibft/fwparam_ibft.c
@@ -415,7 +415,7 @@ char *search_ibft(unsigned char *start, int
length)
cur_ptr = (unsigned char *)start;
for (cur_ptr = (unsigned char *)start;
-cur_ptr (start + length);
+cur_ptr (start + length - strlen(iBFTSTR));
cur_ptr++) {
if (memcmp(cur_ptr, iBFTSTR,strlen(iBFTSTR)))
continue;
--
You received this message because you are subscribed to the Google Groups
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com.
To unsubscribe from this group, send email to
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/open-iscsi?hl=en.
Re: open-iscsi-synchronize-startup-settings
Hi,
On Aug 17, 2:07 pm, s...@i3.noreply.com wrote:
From e7e8d62b02361c05e857cd87a68855725c3a72c7 Mon Sep 17 00:00:00 2001
From: Hannes Reinecke h...@suse.de
Date: Fri, 17 Jul 2009 16:00:39 +0200
Subject: [PATCH] Synchronize startup settings
does not apply against current git tree. This one does:
--- a/usr/iscsiadm.c
+++ b/usr/iscsiadm.c
@@ -1585,6 +1585,26 @@ static int exec_node_op(int op, int do_login,
int do_logout,
set_param.value = value;
rc = for_each_matched_rec(rec, set_param, idbm_node_set_param);
+
+ /*
+ * Compat hack:
+ * node.startup and node.conn[0].startup must be kept
+ * in sync so as not to confuse --loginall and --logoutall
+ */
+ if (!strcmp(name, node.startup)) {
+ log_debug(1, synch node.conn[0].startup mode);
+ set_param.name = node.conn[0].startup;
+ set_param.value = value;
+ rc = for_each_matched_rec(rec, set_param,
idbm_node_set_param);
+ }
+
+ if (!strcmp(name, node.conn[0].startup)) {
+ log_debug(1, synch node.startup modes);
+ set_param.name = node.startup;
+ set_param.value = value;
+ rc = for_each_matched_rec(rec, set_param,
idbm_node_set_param);
+ }
+
goto out;
} else if (op == OP_DELETE) {
rc = for_each_matched_rec(rec, NULL, delete_node);
Best regards,
Craig
--
You received this message because you are subscribed to the Google Groups
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com.
To unsubscribe from this group, send email to
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/open-iscsi?hl=en.
Re: Antw: [PATCH] open-iscsi-ldflags.patch
Hi, -CFLAGS += $(OPTFLAGS) -O2 -fno-inline -Wall -Wstrict-prototypes -g +CFLAGS += $(OPTFLAGS) $(LDFLAGS) -Wall -Wstrict-prototypes -g Now $(LDFLAGS) are duplicated, right? Ulrich I am really bad at this. (: It's all good now, I hope. diff --git a/usr/Makefile b/usr/Makefile index 3ee0cb4..dcf78c2 100644 --- a/usr/Makefile +++ b/usr/Makefile @@ -30,7 +30,7 @@ DCB_OBJ= endif endif -OPTFLAGS ?= -O2 -g +OPTFLAGS ?= -O2 -g -fno-inline $(LDFLAGS) WARNFLAGS ?= -Wall -Wstrict-prototypes CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../include -I. -I../utils/open- isns \ -D$(OSNAME) $(IPC_CFLAGS) diff --git a/utils/Makefile b/utils/Makefile index 2c7e891..79c6f8e 100644 --- a/utils/Makefile +++ b/utils/Makefile @@ -1,6 +1,6 @@ # This Makefile will work only with GNU make. -CFLAGS += $(OPTFLAGS) -O2 -fno-inline -Wall -Wstrict-prototypes -g +CFLAGS += $(OPTFLAGS) -Wall -Wstrict-prototypes -g PROGRAMS = iscsi-iname all: $(PROGRAMS) diff --git a/utils/fwparam_ibft/Makefile b/utils/fwparam_ibft/Makefile index ca07b76..9276722 100644 --- a/utils/fwparam_ibft/Makefile +++ b/utils/fwparam_ibft/Makefile @@ -28,7 +28,7 @@ CLEANFILES = $(OBJS) *.output *~ OPTFLAGS ?= -O2 -g -fPIC WARNFLAGS ?= -Wall -Wstrict-prototypes -CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../../include -I../../usr +CFLAGS += $(OPTFLAGS) $(LDFLAGS) $(WARNFLAGS) -I../../include -I../../ usr all: $(OBJS) -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: Unable to clone open-iscsi git tree
Hi, *.kernel.org is down for maintainance. See http://lwn.net/Articles/457142/ - Craig On 10 Sep., 21:37, Vivek S vivek...@gmail.com wrote: Hi, I get the below error when I try to clone the open-iscsi git tree Cloning into open-iscsi... git.kernel.org[0: 92.242.132.8]: errno=Connection timed out fatal: unable to connect a socket (Connection timed out) I am on Ubuntu 11.04 32 bit. Kindly help me. Thank you, Vivek S -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
