Re: [PATCH] cxgb4i: tcp push bit fix

2012-06-29 Thread Mike Christie

On 06/28/2012 06:49 PM, k...@chelsio.com wrote:

[PATCH] cxgb4i: tcp push bit fix

From: Karen Xie k...@chelsio.com

Fixed the parentheses so the tcp push bit would be sent properly.

Signed-off-by: Karen Xie k...@chelsio.com


Looks ok to me.

Reviewed-by: Mike Christie micha...@cs.wisc.edu

--
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com.
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/open-iscsi?hl=en.



[PATCH] cxgb4i: tcp push bit fix

2012-06-28 Thread kxie
[PATCH] cxgb4i: tcp push bit fix

From: Karen Xie k...@chelsio.com

Fixed the parentheses so the tcp push bit would be sent properly.

Signed-off-by: Karen Xie k...@chelsio.com
---
 drivers/scsi/cxgbi/cxgb4i/cxgb4i.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c 
b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
index 5a4a3bf..9bfc348 100644
--- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
+++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
@@ -438,8 +438,8 @@ static inline void make_tx_data_wr(struct cxgbi_sock *csk, 
struct sk_buff *skb,
if (submode)
wr_ulp_mode = FW_OFLD_TX_DATA_WR_ULPMODE(ULP2_MODE_ISCSI) |
FW_OFLD_TX_DATA_WR_ULPSUBMODE(submode);
-   req-tunnel_to_proxy = htonl(wr_ulp_mode) |
-FW_OFLD_TX_DATA_WR_SHOVE(skb_peek(csk-write_queue) ? 0 : 1);
+   req-tunnel_to_proxy = htonl(wr_ulp_mode |
+FW_OFLD_TX_DATA_WR_SHOVE(skb_peek(csk-write_queue) ? 0 : 1));
req-plen = htonl(len);
if (!cxgbi_sock_flag(csk, CTPF_TX_DATA_SENT))
cxgbi_sock_set_flag(csk, CTPF_TX_DATA_SENT);

-- 
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com.
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/open-iscsi?hl=en.