Re: [PATCH] iBFT 'origin' is an enum, not a string

[The Lee-Man]

I have not seen any objections, so I'm going to merge the pull request on 
github for this patch.

On Saturday, November 12, 2016 at 11:50:17 AM UTC-8, The Lee-Man wrote:
>
> From: Lee Duncan  
>
> A recent change, commit 4959a89f421fdebc, modified open-iscsi 
> to treat the "origin" field as an enum, not a character 
> string. But one spot was missed. 
> --- 
>  utils/fwparam_ibft/fwparam_ibft_sysfs.c | 3 +-- 
>  1 file changed, 1 insertion(+), 2 deletions(-) 
>
> diff --git a/utils/fwparam_ibft/fwparam_ibft_sysfs.c 
> b/utils/fwparam_ibft/fwparam_ibft_sysfs.c 
> index 2dc6f6d5fe54..019fc19184bb 100644 
> --- a/utils/fwparam_ibft/fwparam_ibft_sysfs.c 
> +++ b/utils/fwparam_ibft/fwparam_ibft_sysfs.c 
> @@ -201,8 +201,7 @@ static int fill_nic_context(char *id, struct 
> boot_context *context) 
>sizeof(context->secondary_dns)); 
>  sysfs_get_str(id, IBFT_SUBSYS, "dhcp", context->dhcp, 
>sizeof(context->dhcp)); 
> -sysfs_get_str(id, IBFT_SUBSYS, "origin", context->origin, 
> -  sizeof(context->origin)); 
> +sysfd_get_int(id, IBFT_SUBSYS, "origin", >origin); 
>  return 0; 
>  } 
>   
> -- 
> 2.1.4 
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

[PATCH] iBFT 'origin' is an enum, not a string

[leeman . duncan]

From: Lee Duncan 

A recent change, commit 4959a89f421fdebc, modified open-iscsi
to treat the "origin" field as an enum, not a character
string. But one spot was missed.
---
 utils/fwparam_ibft/fwparam_ibft_sysfs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/utils/fwparam_ibft/fwparam_ibft_sysfs.c 
b/utils/fwparam_ibft/fwparam_ibft_sysfs.c
index 2dc6f6d5fe54..019fc19184bb 100644
--- a/utils/fwparam_ibft/fwparam_ibft_sysfs.c
+++ b/utils/fwparam_ibft/fwparam_ibft_sysfs.c
@@ -201,8 +201,7 @@ static int fill_nic_context(char *id, struct boot_context 
*context)
  sizeof(context->secondary_dns));
sysfs_get_str(id, IBFT_SUBSYS, "dhcp", context->dhcp,
  sizeof(context->dhcp));
-   sysfs_get_str(id, IBFT_SUBSYS, "origin", context->origin,
- sizeof(context->origin));
+   sysfd_get_int(id, IBFT_SUBSYS, "origin", >origin);
return 0;
 }
 
-- 
2.1.4

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Re: [PATCH] iBFT 'origin' is an enum, not a string

[Mike Christie]

On 7/10/15, 2:08 PM, leeman.dun...@gmail.com wrote:

From: Lee Duncan ldun...@suse.com

The iBFT 'origin' value is read in one place correctly
as an integer. This fixes the place where it was
treated as a string.
---
  utils/fwparam_ibft/fwparam_ibft_sysfs.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/utils/fwparam_ibft/fwparam_ibft_sysfs.c 
b/utils/fwparam_ibft/fwparam_ibft_sysfs.c
index 2dc6f6d5fe54..019fc19184bb 100644
--- a/utils/fwparam_ibft/fwparam_ibft_sysfs.c
+++ b/utils/fwparam_ibft/fwparam_ibft_sysfs.c
@@ -201,8 +201,7 @@ static int fill_nic_context(char *id, struct boot_context 
*context)
  sizeof(context-secondary_dns));
sysfs_get_str(id, IBFT_SUBSYS, dhcp, context-dhcp,
  sizeof(context-dhcp));
-   sysfs_get_str(id, IBFT_SUBSYS, origin, context-origin,
- sizeof(context-origin));
+   sysfd_get_int(id, IBFT_SUBSYS, origin, context-origin);
return 0;
  }



Merged in commit cab532bab9886f666518e18a6ef6b56b09d73864. Thanks.

--
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

[PATCH] iBFT 'origin' is an enum, not a string

[leeman . duncan]

From: Lee Duncan ldun...@suse.com

The iBFT 'origin' value is read in one place correctly
as an integer. This fixes the place where it was
treated as a string.
---
 utils/fwparam_ibft/fwparam_ibft_sysfs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/utils/fwparam_ibft/fwparam_ibft_sysfs.c 
b/utils/fwparam_ibft/fwparam_ibft_sysfs.c
index 2dc6f6d5fe54..019fc19184bb 100644
--- a/utils/fwparam_ibft/fwparam_ibft_sysfs.c
+++ b/utils/fwparam_ibft/fwparam_ibft_sysfs.c
@@ -201,8 +201,7 @@ static int fill_nic_context(char *id, struct boot_context 
*context)
  sizeof(context-secondary_dns));
sysfs_get_str(id, IBFT_SUBSYS, dhcp, context-dhcp,
  sizeof(context-dhcp));
-   sysfs_get_str(id, IBFT_SUBSYS, origin, context-origin,
- sizeof(context-origin));
+   sysfd_get_int(id, IBFT_SUBSYS, origin, context-origin);
return 0;
 }
 
-- 
2.1.4

-- 
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.