Re: [PATCH] iscsi: Kconfig option for debug prints.

2009-02-09 Thread Mike Christie
Boaz Harrosh wrote: Mike Christie wrote: Boaz Harrosh wrote: Remove the dark ages /* define debug_print */ in code, to use a Kconfig option. With a system like Kconfig, in code, commented out, configuration options are slavery and hard work. (version control, manual edit ... need I say

Re: [PATCH] iscsi: Kconfig option for debug prints.

2009-01-14 Thread Randy Dunlap
Boaz Harrosh wrote: Remove the dark ages /* define debug_print */ in code, to use a Kconfig option. With a system like Kconfig, in code, commented out, configuration options are slavery and hard work. (version control, manual edit ... need I say more) I've used an int config bit-mask so

[PATCH] iscsi: Kconfig option for debug prints.

2009-01-12 Thread Boaz Harrosh
Remove the dark ages /* define debug_print */ in code, to use a Kconfig option. With a system like Kconfig, in code, commented out, configuration options are slavery and hard work. (version control, manual edit ... need I say more) I've used an int config bit-mask so more areas of code can be

Re: [PATCH] iscsi: Kconfig option for debug prints.

2009-01-12 Thread Boaz Harrosh
Boaz Harrosh wrote: Remove the dark ages /* define debug_print */ in code, to use a Kconfig option. With a system like Kconfig, in code, commented out, configuration options are slavery and hard work. (version control, manual edit ... need I say more) I've used an int config bit-mask so

Re: [PATCH] iscsi: Kconfig option for debug prints.

2009-01-12 Thread Mike Christie
Boaz Harrosh wrote: Boaz Harrosh wrote: Remove the dark ages /* define debug_print */ in code, to use a Kconfig option. With a system like Kconfig, in code, commented out, configuration options are slavery and hard work. (version control, manual edit ... need I say more) I've used an int

Re: [PATCH] iscsi: Kconfig option for debug prints.

2009-01-12 Thread Boaz Harrosh
Mike Christie wrote: Boaz Harrosh wrote: Boaz Harrosh wrote: Remove the dark ages /* define debug_print */ in code, to use a Kconfig option. With a system like Kconfig, in code, commented out, configuration options are slavery and hard work. (version control, manual edit ... need I say

Re: [PATCH] iscsi: Kconfig option for debug prints.

2009-01-12 Thread Boaz Harrosh
Randy Dunlap wrote: Boaz Harrosh wrote: Remove the dark ages /* define debug_print */ in code, to use a Kconfig option. With a system like Kconfig, in code, commented out, configuration options are slavery and hard work. (version control, manual edit ... need I say more) I've used an int