Re: Antw: Re: [PATCH] iscsi_tcp set SO_LINGER to abort connection for error handling

2016-03-04 Thread Chris Leech
On Fri, Mar 04, 2016 at 08:27:14AM +0100, Ulrich Windl wrote: > Hi! > > I always thought SO_LINGER only has an effect on connections that are > (partially) closed only: So if there is some network outage on a TCP > connection and the connection is still considered established, would > it help? >

Antw: Re: [PATCH] iscsi_tcp set SO_LINGER to abort connection for error handling

2016-03-03 Thread Ulrich Windl
Hi! I always thought SO_LINGER only has an effect on connections that are (partially) closed only: So if there is some network outage on a TCP connection and the connection is still considered established, would it help? Regards, Ulrich >>> Chris Leech schrieb am

Re: [PATCH] iscsi_tcp set SO_LINGER to abort connection for error handling

2016-03-03 Thread Chris Leech
On Thu, Mar 03, 2016 at 07:09:14PM -0600, Mike Christie wrote: > On 03/03/2016 06:09 PM, Chris Leech wrote: > > When requests are being failed it's important to abort the TCP > > connection rather than let TCP wait and attempt a graceful shutdown. > > > > That can be accomplished by setting the

Re: [PATCH] iscsi_tcp set SO_LINGER to abort connection for error handling

2016-03-03 Thread Mike Christie
On 03/03/2016 06:09 PM, Chris Leech wrote: > When requests are being failed it's important to abort the TCP > connection rather than let TCP wait and attempt a graceful shutdown. > > That can be accomplished by setting the SO_LINGER socket option with a > linger time of 0 to drop queued data and

[PATCH] iscsi_tcp set SO_LINGER to abort connection for error handling

2016-03-03 Thread Chris Leech
When requests are being failed it's important to abort the TCP connection rather than let TCP wait and attempt a graceful shutdown. That can be accomplished by setting the SO_LINGER socket option with a linger time of 0 to drop queued data and close the connection with a RST instead of a FIN.