Re: Antw: [PATCH] open-iscsi-ldflags.patch
Hi, -CFLAGS += $(OPTFLAGS) -O2 -fno-inline -Wall -Wstrict-prototypes -g +CFLAGS += $(OPTFLAGS) $(LDFLAGS) -Wall -Wstrict-prototypes -g Now $(LDFLAGS) are duplicated, right? Ulrich I am really bad at this. (: It's all good now, I hope. diff --git a/usr/Makefile b/usr/Makefile index 3ee0cb4..dcf78c2 100644 --- a/usr/Makefile +++ b/usr/Makefile @@ -30,7 +30,7 @@ DCB_OBJ= endif endif -OPTFLAGS ?= -O2 -g +OPTFLAGS ?= -O2 -g -fno-inline $(LDFLAGS) WARNFLAGS ?= -Wall -Wstrict-prototypes CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../include -I. -I../utils/open- isns \ -D$(OSNAME) $(IPC_CFLAGS) diff --git a/utils/Makefile b/utils/Makefile index 2c7e891..79c6f8e 100644 --- a/utils/Makefile +++ b/utils/Makefile @@ -1,6 +1,6 @@ # This Makefile will work only with GNU make. -CFLAGS += $(OPTFLAGS) -O2 -fno-inline -Wall -Wstrict-prototypes -g +CFLAGS += $(OPTFLAGS) -Wall -Wstrict-prototypes -g PROGRAMS = iscsi-iname all: $(PROGRAMS) diff --git a/utils/fwparam_ibft/Makefile b/utils/fwparam_ibft/Makefile index ca07b76..9276722 100644 --- a/utils/fwparam_ibft/Makefile +++ b/utils/fwparam_ibft/Makefile @@ -28,7 +28,7 @@ CLEANFILES = $(OBJS) *.output *~ OPTFLAGS ?= -O2 -g -fPIC WARNFLAGS ?= -Wall -Wstrict-prototypes -CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../../include -I../../usr +CFLAGS += $(OPTFLAGS) $(LDFLAGS) $(WARNFLAGS) -I../../include -I../../ usr all: $(OBJS) -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: Antw: [PATCH] open-iscsi-ldflags.patch
Foo Bar cr...@haquarter.de schrieb am 26.08.2011 um 18:39 in Nachricht 352302b3-b77c-49cc-bc79-7c13ef684158@ea4g2000vbb.googlegroups. com: While patching it: Shouldn't -O2 -fno-inline be part of $(OPTFLAGS)? Hi Craig! So why add $(LDFLAGS) to $(OPTFLAGS)? Ulrich I guess so - here is the patch with fixed OPTFLAGS, it's ok for merging now. :) Best regardsm Craig diff --git a/usr/Makefile b/usr/Makefile index 3ee0cb4..dcf78c2 100644 --- a/usr/Makefile +++ b/usr/Makefile @@ -30,7 +30,7 @@ DCB_OBJ= endif endif -OPTFLAGS ?= -O2 -g +OPTFLAGS ?= -O2 -g -fno-inline $(LDFLAGS) ??? WARNFLAGS ?= -Wall -Wstrict-prototypes CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../include -I. -I../utils/open- isns \ -D$(OSNAME) $(IPC_CFLAGS) diff --git a/utils/Makefile b/utils/Makefile index 2c7e891..42c36ce 100644 --- a/utils/Makefile +++ b/utils/Makefile @@ -1,6 +1,6 @@ # This Makefile will work only with GNU make. -CFLAGS += $(OPTFLAGS) -O2 -fno-inline -Wall -Wstrict-prototypes -g +CFLAGS += $(OPTFLAGS) $(LDFLAGS) -Wall -Wstrict-prototypes -g Now $(LDFLAGS) are duplicated, right? Ulrich PROGRAMS = iscsi-iname all: $(PROGRAMS) diff --git a/utils/fwparam_ibft/Makefile b/utils/fwparam_ibft/Makefile index ca07b76..9276722 100644 --- a/utils/fwparam_ibft/Makefile +++ b/utils/fwparam_ibft/Makefile @@ -28,7 +28,7 @@ CLEANFILES = $(OBJS) *.output *~ OPTFLAGS ?= -O2 -g -fPIC WARNFLAGS ?= -Wall -Wstrict-prototypes -CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../../include -I../../usr +CFLAGS += $(OPTFLAGS) $(LDFLAGS) $(WARNFLAGS) -I../../include -I../../ usr all: $(OBJS) -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: Antw: [PATCH] open-iscsi-ldflags.patch
While patching it: Shouldn't -O2 -fno-inline be part of $(OPTFLAGS)? Ulrich I guess so - here is the patch with fixed OPTFLAGS, it's ok for merging now. :) Best regardsm Craig diff --git a/usr/Makefile b/usr/Makefile index 3ee0cb4..dcf78c2 100644 --- a/usr/Makefile +++ b/usr/Makefile @@ -30,7 +30,7 @@ DCB_OBJ= endif endif -OPTFLAGS ?= -O2 -g +OPTFLAGS ?= -O2 -g -fno-inline $(LDFLAGS) WARNFLAGS ?= -Wall -Wstrict-prototypes CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../include -I. -I../utils/open- isns \ -D$(OSNAME) $(IPC_CFLAGS) diff --git a/utils/Makefile b/utils/Makefile index 2c7e891..42c36ce 100644 --- a/utils/Makefile +++ b/utils/Makefile @@ -1,6 +1,6 @@ # This Makefile will work only with GNU make. -CFLAGS += $(OPTFLAGS) -O2 -fno-inline -Wall -Wstrict-prototypes -g +CFLAGS += $(OPTFLAGS) $(LDFLAGS) -Wall -Wstrict-prototypes -g PROGRAMS = iscsi-iname all: $(PROGRAMS) diff --git a/utils/fwparam_ibft/Makefile b/utils/fwparam_ibft/Makefile index ca07b76..9276722 100644 --- a/utils/fwparam_ibft/Makefile +++ b/utils/fwparam_ibft/Makefile @@ -28,7 +28,7 @@ CLEANFILES = $(OBJS) *.output *~ OPTFLAGS ?= -O2 -g -fPIC WARNFLAGS ?= -Wall -Wstrict-prototypes -CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../../include -I../../usr +CFLAGS += $(OPTFLAGS) $(LDFLAGS) $(WARNFLAGS) -I../../include -I../../ usr all: $(OBJS) -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Antw: [PATCH] open-iscsi-ldflags.patch
Foo Bar cr...@haquarter.de schrieb am 17.08.2011 um 17:16 in Nachricht 16cceaff-3ebb-4a98-a85f-137e348b4...@p10g2000yqi.googlegroups.com: Hi, attached you will find a patch for the Makefile to respect LDFLAGS. It would be nice to see it in the next release, thanks! diff --git a/usr/Makefile b/usr/Makefile index 3ee0cb4..5e3128a 100644 --- a/usr/Makefile +++ b/usr/Makefile @@ -30,7 +30,7 @@ DCB_OBJ= endif endif -OPTFLAGS ?= -O2 -g +OPTFLAGS ?= -O2 -g $(LDFLAGS) WARNFLAGS ?= -Wall -Wstrict-prototypes CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../include -I. -I../utils/open- isns \ -D$(OSNAME) $(IPC_CFLAGS) diff --git a/utils/Makefile b/utils/Makefile index 2c7e891..e88265c 100644 --- a/utils/Makefile +++ b/utils/Makefile @@ -1,6 +1,6 @@ # This Makefile will work only with GNU make. -CFLAGS += $(OPTFLAGS) -O2 -fno-inline -Wall -Wstrict-prototypes -g +CFLAGS += $(OPTFLAGS) $(LDFLAGS) -O2 -fno-inline -Wall -Wstrict- While patching it: Shouldn't -O2 -fno-inline be part of $(OPTFLAGS)? Ulrich prototypes -g PROGRAMS = iscsi-iname all: $(PROGRAMS) diff --git a/utils/fwparam_ibft/Makefile b/utils/fwparam_ibft/Makefile index ca07b76..64823e4 100644 --- a/utils/fwparam_ibft/Makefile +++ b/utils/fwparam_ibft/Makefile @@ -26,7 +26,7 @@ OBJS := fw_entry.o fwparam_sysfs.o $ (SYSDEPS_OBJS) ../../usr/iscsi_net_util.o OBJS += prom_lex.o prom_parse.tab.o fwparam_ppc.o CLEANFILES = $(OBJS) *.output *~ -OPTFLAGS ?= -O2 -g -fPIC +OPTFLAGS ?= -O2 -g -fPIC $(LDFLAGS) WARNFLAGS ?= -Wall -Wstrict-prototypes CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../../include -I../../usr -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
[PATCH] open-iscsi-ldflags.patch
Hi, attached you will find a patch for the Makefile to respect LDFLAGS. It would be nice to see it in the next release, thanks! diff --git a/usr/Makefile b/usr/Makefile index 3ee0cb4..5e3128a 100644 --- a/usr/Makefile +++ b/usr/Makefile @@ -30,7 +30,7 @@ DCB_OBJ= endif endif -OPTFLAGS ?= -O2 -g +OPTFLAGS ?= -O2 -g $(LDFLAGS) WARNFLAGS ?= -Wall -Wstrict-prototypes CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../include -I. -I../utils/open- isns \ -D$(OSNAME) $(IPC_CFLAGS) diff --git a/utils/Makefile b/utils/Makefile index 2c7e891..e88265c 100644 --- a/utils/Makefile +++ b/utils/Makefile @@ -1,6 +1,6 @@ # This Makefile will work only with GNU make. -CFLAGS += $(OPTFLAGS) -O2 -fno-inline -Wall -Wstrict-prototypes -g +CFLAGS += $(OPTFLAGS) $(LDFLAGS) -O2 -fno-inline -Wall -Wstrict- prototypes -g PROGRAMS = iscsi-iname all: $(PROGRAMS) diff --git a/utils/fwparam_ibft/Makefile b/utils/fwparam_ibft/Makefile index ca07b76..64823e4 100644 --- a/utils/fwparam_ibft/Makefile +++ b/utils/fwparam_ibft/Makefile @@ -26,7 +26,7 @@ OBJS := fw_entry.o fwparam_sysfs.o $ (SYSDEPS_OBJS) ../../usr/iscsi_net_util.o OBJS += prom_lex.o prom_parse.tab.o fwparam_ppc.o CLEANFILES = $(OBJS) *.output *~ -OPTFLAGS ?= -O2 -g -fPIC +OPTFLAGS ?= -O2 -g -fPIC $(LDFLAGS) WARNFLAGS ?= -Wall -Wstrict-prototypes CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../../include -I../../usr -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: [PATCH] open-iscsi-ldflags.patch
On 08/17/2011 10:16 AM, Foo Bar wrote: Hi, attached you will find a patch for the Makefile to respect LDFLAGS. It would be nice to see it in the next release, thanks! diff --git a/usr/Makefile b/usr/Makefile index 3ee0cb4..5e3128a 100644 --- a/usr/Makefile +++ b/usr/Makefile @@ -30,7 +30,7 @@ DCB_OBJ= endif endif -OPTFLAGS ?= -O2 -g +OPTFLAGS ?= -O2 -g $(LDFLAGS) WARNFLAGS ?= -Wall -Wstrict-prototypes CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../include -I. -I../utils/open- isns \ -D$(OSNAME) $(IPC_CFLAGS) diff --git a/utils/Makefile b/utils/Makefile index 2c7e891..e88265c 100644 --- a/utils/Makefile +++ b/utils/Makefile @@ -1,6 +1,6 @@ # This Makefile will work only with GNU make. -CFLAGS += $(OPTFLAGS) -O2 -fno-inline -Wall -Wstrict-prototypes -g +CFLAGS += $(OPTFLAGS) $(LDFLAGS) -O2 -fno-inline -Wall -Wstrict- prototypes -g PROGRAMS = iscsi-iname all: $(PROGRAMS) diff --git a/utils/fwparam_ibft/Makefile b/utils/fwparam_ibft/Makefile index ca07b76..64823e4 100644 --- a/utils/fwparam_ibft/Makefile +++ b/utils/fwparam_ibft/Makefile @@ -26,7 +26,7 @@ OBJS := fw_entry.o fwparam_sysfs.o $ (SYSDEPS_OBJS) ../../usr/iscsi_net_util.o OBJS += prom_lex.o prom_parse.tab.o fwparam_ppc.o CLEANFILES = $(OBJS) *.output *~ -OPTFLAGS ?= -O2 -g -fPIC +OPTFLAGS ?= -O2 -g -fPIC $(LDFLAGS) WARNFLAGS ?= -Wall -Wstrict-prototypes CFLAGS += $(OPTFLAGS) $(WARNFLAGS) -I../../include -I../../usr Patch is ok in as far as adding LDFLAGS, but the patch does not apply. -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
