RE: [PATCH 1/2] RFC: Proposal for BSG Interface

2010-05-10 Thread Vikas Chaudhary
Sorry for late response. Please see our comments inline. We are trying to figure out how we can leverage this interface for our offload solution. Thanks, Vikas. +/* + * iSCSI Host Messages + */ + +struct ip_address_subnet_format { + u16 sizeofstructure; Why do we need this field ? +

Re: [PATCH 1/2] RFC: Proposal for BSG Interface

2010-03-18 Thread Boaz Harrosh
On 03/17/2010 08:06 PM, Jayamohan Kallickal wrote: This patch contains the bsg interface based on the bsg interface in FC. What? where? who? how? why? w*\? ... You are proposing a new Kernel ABI/API here right. I think it is not acceptable without a detailed documentation, including every

[PATCH 1/2] RFC: Proposal for BSG Interface

2010-03-17 Thread Jayamohan Kallickal
This patch contains the bsg interface based on the bsg interface in FC. Developed and submitted earlier by James Smart. Signed-off-by: James Smart james.sm...@emulex.com Signed-off-by: Jayamohan Kallickal jayamoh...@serverengines.com --- drivers/scsi/scsi_transport_iscsi.c | 459