Re: [PATCH 1/2] libiscsi: Annotate locking assumptions

[Chris Leech]

On Thu, Mar 01, 2018 at 10:07:47AM -0800, Bart Van Assche wrote:
> This patch avoids that sparse reports the following:
> 
> drivers/scsi/libiscsi.c:1844:23: warning: context imbalance in 
> 'iscsi_exec_task_mgmt_fn' - unexpected unlock
> 
> Signed-off-by: Bart Van Assche 
> Cc: Lee Duncan 
> Cc: Chris Leech 
> ---
>  drivers/scsi/libiscsi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index 15a2fef51e38..b39bfdfec337 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -1832,6 +1832,7 @@ static void iscsi_tmf_timedout(struct timer_list *t)
>  static int iscsi_exec_task_mgmt_fn(struct iscsi_conn *conn,
>  struct iscsi_tm *hdr, int age,
>  int timeout)
> + __must_hold(>frwd_lock)
>  {
>   struct iscsi_session *session = conn->session;
>   struct iscsi_task *task;
> -- 
> 2.16.2

Signed-off-by: Chris Leech 

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

[PATCH 1/2] libiscsi: Annotate locking assumptions

[Bart Van Assche]

This patch avoids that sparse reports the following:

drivers/scsi/libiscsi.c:1844:23: warning: context imbalance in 
'iscsi_exec_task_mgmt_fn' - unexpected unlock

Signed-off-by: Bart Van Assche 
Cc: Lee Duncan 
Cc: Chris Leech 
---
 drivers/scsi/libiscsi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 15a2fef51e38..b39bfdfec337 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -1832,6 +1832,7 @@ static void iscsi_tmf_timedout(struct timer_list *t)
 static int iscsi_exec_task_mgmt_fn(struct iscsi_conn *conn,
   struct iscsi_tm *hdr, int age,
   int timeout)
+   __must_hold(>frwd_lock)
 {
struct iscsi_session *session = conn->session;
struct iscsi_task *task;
-- 
2.16.2

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.