Re: [PATCHES] Fixup iBFT and IPv6, some cleanup
On Nov 13, 2014, at 5:56 PM, The Lee-Man leeman.dun...@gmail.com wrote:
On Tuesday, November 11, 2014 8:25:56 PM UTC-8, Mike Christie wrote:
On 10/30/2014 08:16 PM, The Lee-Man wrote:
0002-Represent-DHCP-origin-as-an-integer-not-string.patch
This just changes the origin attribute from a string, to a number,
which
is what it really is.
Could you send me a link to where origin is defined? In the doc I have
it is a dead link.
This is defined in the iBFT document, available here on the web here: iBFT
Layout - Microsoft
(if my hper-link works)
In section 3.6 NIC Structure, the table shows that origin 1 byte long at
offset 23 bytes. And table points at a C++ definition of the values here:
http://msdn.microsoft.com/en-us/library/aa366281.aspx
It looks like:
typedef enum {
IpPrefixOriginOther= 0,
IpPrefixOriginManual,
IpPrefixOriginWellKnown,
IpPrefixOriginDhcp,
IpPrefixOriginRouterAdvertisement,
IpPrefixOriginUnchanged= 16
} IP_PREFIX_ORIGIN;
The open-iscsi code current checks this for the value 3 (i.e. a string
representing the number 3), and our code already has a patch that instead
reads this value in as an integer, and then compares it with the number 3.
Could you add a enum for these values in fw_context.h and then check for it
instead of the numerical value?
--
You received this message because you are subscribed to the Google Groups
open-iscsi group.
To unsubscribe from this group and stop receiving emails from it, send an email
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
Re: [PATCHES] Fixup iBFT and IPv6, some cleanup
On Friday, November 14, 2014 9:12:41 AM UTC-8, Mike Christie wrote:
On Nov 13, 2014, at 5:56 PM, The Lee-Man leeman...@gmail.com
javascript: wrote:
On Tuesday, November 11, 2014 8:25:56 PM UTC-8, Mike Christie wrote:
On 10/30/2014 08:16 PM, The Lee-Man wrote:
0002-Represent-DHCP-origin-as-an-integer-not-string.patch
This just changes the origin attribute from a string, to a
number,
which
is what it really is.
Could you send me a link to where origin is defined? In the doc I have
it is a dead link.
This is defined in the iBFT document, available here on the web here: iBFT
Layout - Microsoft
http://www.google.com/url?sa=trct=jq=esrc=ssource=webcd=1ved=0CCAQFjAAurl=http%3A%2F%2Fdownload.microsoft.com%2Fdownload%2F7%2FE%2F7%2F7E7662CF-CBEA-470B-A97E-CE7CE0D98DC2%2FiBFT.docxei=TjZlVKeNKYzVoASDn4GAAwusg=AFQjCNHY7NV8Y8wg4cHMzEOHi-4oUnWNLQsig2=9mkbWXrDlIra2lY3Qbe-Vgbvm=bv.79400599,d.cGU
(if my hper-link works)
In section 3.6 NIC Structure, the table shows that origin 1 byte long at
offset 23 bytes. And table points at a C++ definition of the values here:
http://msdn.microsoft.com/en-us/library/aa366281.aspx
It looks like:
typedef enum {
IpPrefixOriginOther= 0,
IpPrefixOriginManual,
IpPrefixOriginWellKnown,
IpPrefixOriginDhcp,
IpPrefixOriginRouterAdvertisement,
IpPrefixOriginUnchanged= 16
} IP_PREFIX_ORIGIN;
The open-iscsi code current checks this for the value 3 (i.e. a string
representing the number 3), and our code already has a patch that instead
reads this value in as an integer, and then compares it with the number 3.
Could you add a enum for these values in fw_context.h and then check for
it instead of the numerical value?
I will submit the set again against current 'master' branch, minus patch 4
(for now).
--
You received this message because you are subscribed to the Google Groups
open-iscsi group.
To unsubscribe from this group and stop receiving emails from it, send an email
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.
Re: [PATCHES] Fixup iBFT and IPv6, some cleanup
On Tuesday, November 11, 2014 6:11:51 PM UTC-8, Mike Christie wrote: On 10/30/2014 08:16 PM, The Lee-Man wrote: 0003-fwparam_ibft-Check-iBFT-target-and-NIC-flags.patch This was the patch that you had problems with last time, and for good reason, as it checks iBFT flags for Bit-0, as per the iBFT standard, but as you pointed out many adapters don't follow the standard and instead set Bit-1. So now we just check for any bit being set. This *has* been tested with more adapters. Did you by any chance take note of what cards do what? Mostly interested in bnx2i, cxgb*i, intel, and the ibm boxes with the initiator on them. No, I'm afraid I'm still trying to build up a library of relevant cards, since I only have a few. If you do not know, do not worry. Just wanted to document it somewhere if we knew. -- You received this message because you are subscribed to the Google Groups open-iscsi group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.
RE: [PATCHES] Fixup iBFT and IPv6, some cleanup
Did you by any chance take note of what cards do what? Mostly interested in bnx2i, cxgb*i, intel, and the ibm boxes with the initiator on them. [Anish Bhatt] I’d be happy with any cxgb*I support you need. I happened to be looking at all the stuff under #ifdef OFFLOAD_BOOT_SUPPORTED fairly recently myself. No, I'm afraid I'm still trying to build up a library of relevant cards, since I only have a few. If you do not know, do not worry. Just wanted to document it somewhere if we knew. -- You received this message because you are subscribed to the Google Groups open-iscsi group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.commailto:open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.commailto:open-iscsi@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups open-iscsi group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.
Re: [PATCHES] Fixup iBFT and IPv6, some cleanup
On 10/30/2014 08:16 PM, The Lee-Man wrote: 0003-fwparam_ibft-Check-iBFT-target-and-NIC-flags.patch This was the patch that you had problems with last time, and for good reason, as it checks iBFT flags for Bit-0, as per the iBFT standard, but as you pointed out many adapters don't follow the standard and instead set Bit-1. So now we just check for any bit being set. This *has* been tested with more adapters. Did you by any chance take note of what cards do what? Mostly interested in bnx2i, cxgb*i, intel, and the ibm boxes with the initiator on them. If you do not know, do not worry. Just wanted to document it somewhere if we knew. -- You received this message because you are subscribed to the Google Groups open-iscsi group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.
Re: [PATCHES] Fixup iBFT and IPv6, some cleanup
On 10/30/2014 08:16 PM, The Lee-Man wrote: 0002-Represent-DHCP-origin-as-an-integer-not-string.patch This just changes the origin attribute from a string, to a number, which is what it really is. Could you send me a link to where origin is defined? In the doc I have it is a dead link. 0004-Fixup-IPv6-iBFT-interface-description.patch This patch adds prefix-len to the open-iscsi attributes, as it is needed for IPv6, which doesn't use mask like IPv4 does. Could you send me a link to the prefix-len kernel patch that you guys did, or did you reply the mail where I was asking what is it (if so I cannot find it)? For the offload drivers that simulate ibft did they report the correct value in your kernel patch? -- You received this message because you are subscribed to the Google Groups open-iscsi group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To post to this group, send email to open-iscsi@googlegroups.com. Visit this group at http://groups.google.com/group/open-iscsi. For more options, visit https://groups.google.com/d/optout.
