Re: Antw: [PATCH 0/3] Add initial DCB support

2011-02-01 Thread Pasi Kärkkäinen
On Tue, Feb 01, 2011 at 08:51:25AM +0100, Ulrich Windl wrote: Mark Rustad mark.d.rus...@intel.com schrieb am 31.01.2011 um 18:31 in Nachricht 20110131172745.28218.25755.stgit@localhost6.localdomain6: This patch series adds initial DCB support to open-iscsi. In this [...] Hi! I may out

[v2 PATCH 0/3] Add DCB support

2011-02-01 Thread Mark Rustad
This patch series adds initial DCB support to open-iscsi. In this implementation, the application priority mask is fetched from the kernel at session connect time and the highest priority in the mask is chosen and set as a socket priority. Established session will not have their priorities changed

[PATCH 2/3] Add dcb_app.c for DCB support

2011-02-01 Thread Mark Rustad
Add functions to obtain application priority mask from DCB in the kernel. Signed-off-by: Mark Rustad mark.d.rus...@intel.com --- usr/dcb_app.c | 246 + 1 files changed, 246 insertions(+), 0 deletions(-) create mode 100644 usr/dcb_app.c

[PATCH 3/3] Add initial DCB support

2011-02-01 Thread Mark Rustad
Add support for setting priorities provided by DCB in the kernel. This implementation does not track any priority changes which could occur over time. Signed-off-by: Mark Rustad mark.d.rus...@intel.com --- usr/Makefile |4 ++ usr/io.c | 104

[PATCH 1/3] Add dcb_app.h for DCB support

2011-02-01 Thread Mark Rustad
Add header file with prototypes for functions in dcb_app.c. Signed-off-by: Mark Rustad mark.d.rus...@intel.com --- usr/dcb_app.h | 34 ++ 1 files changed, 34 insertions(+), 0 deletions(-) create mode 100644 usr/dcb_app.h diff --git a/usr/dcb_app.h

Re: [PATCH 2/3] Add dcb_app.c for DCB support

2011-02-01 Thread Mike Christie
On 02/01/2011 05:10 PM, Mark Rustad wrote: +static int get_link_ifname(const char *ifname, char *link_ifname) +{ + int ifindex; + + if (sysfs_get_int(ifname, net, iflink,ifindex)) + return EIO; In the rest of the code you use -EXYZ, but here you use the positive

Re: [PATCH 3/3] Add initial DCB support

2011-02-01 Thread Mike Christie
On 02/01/2011 05:10 PM, Mark Rustad wrote: + +static void set_dcb_priority(struct iscsi_conn *conn, const char *devname) +{ + int pri_mask = 0; + + pri_mask = get_dcb_app_pri_by_port(devname, ISCSI_DEFAULT_PORT); + if (pri_mask 0) + log_debug(2, Getting priority

RE: [PATCH 2/3] Add dcb_app.c for DCB support

2011-02-01 Thread Rustad, Mark D
Mike, On Tuesday, February 01, 2011 4:37 PM, Mike Christie wrote: On 02/01/2011 05:10 PM, Mark Rustad wrote: +static int get_link_ifname(const char *ifname, char *link_ifname) +{ + int ifindex; + + if (sysfs_get_int(ifname, net, iflink,ifindex)) + return EIO; In