Re: [RFC_V5 PATCH 3/3] qla4xxx: Add flash node mgmt support

2013-03-08 Thread Mike Christie
On 03/08/2013 04:18 AM, Adheer Chandravanshi wrote: > I guess the confusion is because of the macro names ISCSIOPT_ERL1 and > ISCSIOPT_ERL0. These do not correspond to actual erl level 1 and 0. Ah, I see now. Thanks for the info. Looks ok to me then. Send them to linux-scsi. -- You received thi

Re: [PATCH 3/3] iscsiadm: return error when login fails

2013-03-08 Thread Lee Duncan
Mike Christie Mar 07 01:43AM -0600 wrote: > > On 03/01/2013 06:06 PM, Lee Duncan wrote: > > ISCSI_ERR_SCSI_EH_SESSION_RST = ISCSI_ERR_BASE + 21, > > + ISCSI_ERR_LOGIN_FAILED = ISCSI_ERR_BASE + 22, > > }; > > Those errors are for the iscsi user/kernel interface. > > The errors you

[PATCHv2 2/3] Allow firmware mode to use debug flag

2013-03-08 Thread Lee Duncan
When iscsiadm is called with "-m fw", the debug flag can be useful. Signed-off-by: Hannes Reinecke Signed-off-by: Lee Duncan --- doc/iscsiadm.8 |2 +- usr/iscsiadm.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/iscsiadm.8 b/doc/iscsiadm.8 index 7c209f6..9e

[PATCHv2 3/3] iscsiadm: return error when login fails

2013-03-08 Thread Lee Duncan
When login fails because there are too many sessions we should be returning an error code so that userland is aware that something is amiss. Signed-off-by: Hannes Reinecke Signed-off-by: Lee Duncan --- usr/session_mgmt.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCHv2 1/3] Fix check for return from nice call

2013-03-08 Thread Lee Duncan
The return value from nice() is being checked for less than 0 for an error condition, when it should be checking for "-1". This removes the bogus iscsid startup error message "Could not increase process priority: Success". Signed-off-by: Lee Duncan --- usr/iscsi_util.c |2 +- 1 file changed,

[PATCHv2 0/3] SUSE Patch that should be upstream

2013-03-08 Thread Lee Duncan
Here are 3 patches. The first one is a bug I found in how nice() return value is being checked, and the other two are patches that we have been carrying in the SUSE version of open-iscsi that I wanted to pass upstream. Lee Duncan: [PATCH 1/3] Fix check for return from nice call Hannes Rei