I was going to say node is ok, but I guess some of these sessions could
get created by other tools like iscsistart or anaconda or some lib.
I think it would be nice to print out what entity created the session,
but I am not sure if is that easy. We would have to modify apps to tell
the kernel, then have the kernel export that, and I am not sure if that
is going to be acceptable upstream.
How about just do flash and non-flash. It will then just indicate if it
came from flash info or not.
On 04/15/2013 08:41 AM, Mike Christie wrote:
> I am not a fan of "node" too, but normal might not make sense since
> flash mode might be more "normal" for qlogic hw.
>
> Hate naming ..... :)
>
> On 04/08/2013 05:49 AM, Ulrich Windl wrote:
>> What about "normal" vs. "flash" (maybe not repeat "node" in node context)?
>>
>>>>> Vikas Chaudhary <vikas.chaudh...@qlogic.com> schrieb am 08.04.2013 um
>>>>> 11:19 in
>> Nachricht <3fc4ab8b47ecd546bcd4b361a64beacd28e...@avmb3.qlogic.org>:
>>
>>>
>>> -----Original Message-----
>>> From: Mike Christie <micha...@cs.wisc.edu>
>>> Reply-To: "open-iscsi@googlegroups.com" <open-iscsi@googlegroups.com>
>>> Date: Saturday 6 April 2013 12:43 PM
>>> To: Vikas <vikas.chaudh...@qlogic.com>
>>> Cc: "open-iscsi@googlegroups.com" <open-iscsi@googlegroups.com>, Lalit
>>> Chandivade <lalit.chandiv...@qlogic.com>, Ravi Anand
>>> <ravi.an...@qlogic.com>
>>> Subject: Re: [PATCH 2/2] iscsi tools: Print additional session info for
>>> flashnode session
>>>
>>>> On 4/5/13 6:34 AM, vikas.chaudh...@qlogic.com wrote:
>>>>> From: Vikas Chaudhary <vikas.chaudh...@qlogic.com>
>>>>>
>>>>> Signed-off-by: Vikas Chaudhary <vikas.chaudh...@qlogic.com>
>>>>> ---
>>>>> usr/session_info.c | 24 +++++++++++++++++++-----
>>>>> 1 file changed, 19 insertions(+), 5 deletions(-)
>>>>>
>>>>> diff --git a/usr/session_info.c b/usr/session_info.c
>>>>> index 1f84c49..17c5de8 100644
>>>>> --- a/usr/session_info.c
>>>>> +++ b/usr/session_info.c
>>>>> @@ -64,20 +64,32 @@ void session_info_free_list(struct list_head *list)
>>>>> }
>>>>> }
>>>>>
>>>>> +static char *get_iscsi_node_type(struct session_info *info)
>>>>> +{
>>>>> + int pid = iscsi_sysfs_session_user_created(info->sid);
>>>>> +
>>>>> + if (!pid)
>>>>> + return "(flashnode)";
>>>>> +
>>>>> + return "";
>>>>> +}
>>>>> +
>>>>
>>>> If someone is parsing this and we add another string after this one,
>>>> then they are going to have a difficult time handling "". Can you think
>>>> of a name for the non-flashnode type? I can just edit that into the
>>>> patch when I merge it.
>>>>
>>>> Software-node? Something?
>>>
>>>
>>> How about writing just "node", as these session are created with mode node?
>>>
>>> output will look like:-
>>>
>>> root@localhost: [usr (to_scsi_list_v2)]# ./iscsiadm -m session
>>> qla4xxx: [11] 192.168.1.11:3260,1 iqn.1992-04.com.emc:cx.ckm00101200392.a2
>>> (flashnode)
>>> qla4xxx: [12] 192.168.1.8:3260,3 iqn.1992-04.com.emc:cx.ckm00101200392.a3
>>> (flashnode)
>>> qla4xxx: [13] 192.168.1.12:3260,2 iqn.1992-04.com.emc:cx.ckm00101200392.b2
>>> (flashnode)
>>> qla4xxx: [14] 192.168.1.9:3260,4 iqn.1992-04.com.emc:cx.ckm00101200392.b3
>>> (flashnode)
>>> qla4xxx: [15] 192.168.1.48:3260,1 iqn.2001-04.com.rv-115:storage.0 (node)
>>> qla4xxx: [16] 192.168.1.48:3260,1 iqn.2001-04.com.rv-115:storage.2 (node)
>>> qla4xxx: [17] 192.168.1.48:3260,1 iqn.2001-04.com.rv-115:storage.1 (node)
>>> qla4xxx: [18] 192.168.1.48:3260,1 iqn.2001-04.com.rv-115:storage.3 (node)
>>> qla4xxx: [19] 192.168.1.48:3260,1 iqn.2001-04.com.rv-115:storage.4 (node)
>>>
>>>
>>>
>>> Thanks,
>>> Vikas.
>>>
>>>
>>> ________________________________
>>>
>>> This message and any attached documents contain information from QLogic
>>> Corporation or its wholly-owned subsidiaries that may be confidential. If
>>> you
>>> are not the intended recipient, you may not read, copy, distribute, or use
>>> this information. If you have received this transmission in error, please
>>> notify the sender immediately by reply e-mail and then delete this message.
>>
>>
>>
>>
>>
>
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at http://groups.google.com/group/open-iscsi?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
