Need Code Understanding

2017-02-16 Thread lokesh arora
Hey Referring to the code in file *ioctl.c* *Function: ctldev_open* The function callocs ioctl_sendbuf, ioctl_recvbuf, pdu_sendbuf but those 3 parameters are not being used anywhere. Moreover the function returns *ctrl_fd*, but the variable is never set in the complete file. All those 4 above said

Re: Proposal to make automatic target rescans optional

2017-02-16 Thread Gorka Eguileor
On 16/02, Chris Leech wrote: > Hi Gorka, > > Thanks for the detailed write-up here. > > It seems to me that we have a way to disable automatic kernel/driver > initiated scans (scsi_mod.scan=manual) for just these type of situations, but > with iSCSI we've already moved control to iscsid and are a

Re: Need Code Understanding

2017-02-16 Thread Chris Leech
The code in ioctl.c isn't actually used or built at all. Thanks for reminding me to clean this up. The project at one point was planning on supporting a FreeBSD kernel initiator as well, and ioctl.c is a remnant of that. The code that's actually used to do the iscsid-to-kernel messaging is in

discoverydb commands failing with 0 timeout after "Use timeout when waiting for responses from iscsid" applied

2017-02-16 Thread Chris Leech
After the changeset "Use timeout when waiting for responses from iscsid" discoverydb commands from iscsiadm are apparently running with a 0 timeout and failing when the response from iscsid isn't already in the socket buffer when poll is called. This change seems to fix it. All this can probab