Re: [PATCH] scsi: iscsi_tcp: set BDI_CAP_STABLE_WRITES when data digest enabled

2018-03-15 Thread Lee Duncan
I reviewed this several days before but mistakenly replied only to the open-iscsi list. Signed-off-by: Lee Duncan -- Lee-Man Duncan Sent from my iPhone, dude > On Mar 14, 2018, at 10:11 PM, Martin K. Petersen > wrote: > > >> iscsi tcp will first send out data, then calculate and send dat

Re: [PATCH] scsi: scsi_transport_iscsi: use put_device() instead of kfree()

2018-03-15 Thread Chris Leech
On Wed, Mar 07, 2018 at 05:07:33PM +0530, Arvind Yadav wrote: > Never directly free @dev after calling device_register(), even > if it returned an error! Always use put_device() to give up the > reference initialized. > > Signed-off-by: Arvind Yadav > --- > drivers/scsi/scsi_transport_iscsi.c |

Re: [PATCH] scsi: iscsi_tcp: set BDI_CAP_STABLE_WRITES when data digest enabled

2018-03-15 Thread Chris Leech
On Wed, Mar 07, 2018 at 08:29:03PM +0800, Jianchao Wang wrote: > iscsi tcp will first send out data, then calculate and send data > digest. If we don't have BDI_CAP_STABLE_WRITES, the page cache will > be written in spite of the on going writeback. Consequently, wrong > digest will be got and sent