Re: [PATCH 24/24] osst: add a SPDX tag to osst.c

2019-05-09 Thread Willem Riede
On Thu, May 2, 2019 at 7:19 AM Hannes Reinecke wrote: > On 5/2/19 2:53 PM, Christoph Hellwig wrote: > > On Thu, May 02, 2019 at 08:06:38AM +0200, Hannes Reinecke wrote: > >> On 5/1/19 6:14 PM, Christoph Hellwig wrote: > >>> osst.c is the only osst file missing licensing information. Add a > >>>

Re: [PATCH 24/24] osst: add a SPDX tag to osst.c

2019-05-09 Thread Willem Riede
On Fri, May 3, 2019 at 1:05 AM Hannes Reinecke wrote: > On 5/2/19 9:55 PM, Willem Riede wrote: > > On Thu, May 2, 2019 at 7:19 AM Hannes Reinecke > > wrote: > > > > > > > Maybe it's time to kill osst.c for good ... > > > > > > Yes. I've been thinking about doing

Re: [bug report][scsi blk_mq] data corruption due to a bug in SCSI LLD error handling

2019-05-09 Thread The Lee-Man
I think the point is that the sg path is not equal to the real IO path. You are (currently) never going to get correct error handling from the sg path, which is considered out of band. So what are you trying to do here? Are you really developing software that uses the sg path, and you need

Re: [PATCH 17/24] libsas: switch remaining files to SPDX tags

2019-05-09 Thread John Garry
On 01/05/2019 17:14, Christoph Hellwig wrote: Use the the GPLv2 SPDX tag instead of verbose boilerplate text. Should we update the Kconfig+Makefile similarly? Signed-off-by: Christoph Hellwig --- drivers/scsi/libsas/sas_discover.c | 18 +- drivers/scsi/libsas/sas_event.c