[PATCH] iscsiuio: Fix lookup of IPv6 router address

2015-05-15 Thread Johannes Thumshirn
When iscsiuio performs a lookup in it's routing table for the default router, nothing is returned as ndpc_request() didn't understand the 'GET_DEFAULT_ROUTER_ADDR' request. The solution is to add the request and return the default router address. Signed-off-by: Johannes Thumshirn jthumsh

Re: [PATCH] iscsiuio: Fix lookup of IPv6 router address

2015-05-21 Thread Johannes Thumshirn
Gnetle ping on this On Mon, May 11, 2015 at 01:38:12PM +0200, Johannes Thumshirn wrote: When iscsiuio performs a lookup in it's routing table for the default router, nothing is returned as ndpc_request() didn't understand the 'GET_DEFAULT_ROUTER_ADDR' request. The solution is to add

Re: [PATCH] iscsiuio: Fix lookup of IPv6 router address

2015-05-26 Thread Johannes Thumshirn
Cc: Johannes Thumshirn; Adheer Chandravanshi Subject: Re: [PATCH] iscsiuio: Fix lookup of IPv6 router address Hi, Don't mind if I chime in. From the upstream code, the patch looks good. Just curious at who the caller for that might be? Eddie On Fri, 2015-05-22 at 10:48 -0500, Mike

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

2016-03-09 Thread Johannes Thumshirn
his in user space, though, > than to limit the value range for the session ID here. > > Signed-off-by: Lee Duncan <ldun...@suse.com> Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de

Re: [PATCH] libiscsi: use vzalloc for large allocations in iscsi_pool_init

2017-04-03 Thread Johannes Thumshirn
der allocation ends up failing. > > The kernel will print a warning and dump_stack, like below: There is a series of patches in Andrew's mmotm tree, which introduces a kvmalloc() function, that does exactly what you're looking for. Maybe you want to base your patch o

Re: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

2017-03-09 Thread Johannes Thumshirn
> This looks OK to me. >>>> >>>> Acked-by: Chris Leech <cle...@redhat.com> >>> >>> Thank you for review! Do you have a tree that can take this change? >> >> Hi Elena, >> >> iscsi like fcoe should go via the SCSI tree. > > Tha

Re: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

2017-03-09 Thread Johannes Thumshirn
gned-off-by: Kees Cook <keesc...@chromium.org> >>> Signed-off-by: David Windsor <dwind...@gmail.com> >> >> This looks OK to me. >> >> Acked-by: Chris Leech <cle...@redhat.com> > > Thank you for review! Do you have a tree that can take this change

Re: [PATCH 21/29] drivers, s390: convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t

2017-03-08 Thread Johannes Thumshirn
-after-free situations. The subject is wrong, should be something like "scsi: libfc convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t" but not s390. Other than that Acked-by: Johannes Thumshirn <j...@kernel.org> Turns out that it is better that all these patches go throug

Re: [PATCH 21/29] drivers, s390: convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t

2017-03-06 Thread Johannes Thumshirn
s. The subject is wrong, should be something like "scsi: libfc convert fc_fcp_pkt.ref_cnt from atomic_t to refcount_t" but not s390. Other than that Acked-by: Johannes Thumshirn <j...@kernel.org> -- Johannes Thumshirn

Re: [RFC PATCH 4/6] bsg: refactor ioctl to use regular BSG-command infrastructure for SG_IO

2017-08-10 Thread Johannes Thumshirn
onstruct. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint

Re: [RFC PATCH 5/6] bsg: reduce unnecessary arguments for bsg_map_hdr()

2017-08-10 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [RFC PATCH 6/6] bsg: reduce unnecessary arguments for blk_complete_sgv4_hdr_rq()

2017-08-10 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de> -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard,

Re: [Patch v2 2/2] libiscsi: Remove iscsi_destroy_session

2017-09-14 Thread Johannes Thumshirn
; Signed-off-by: Khazhismel Kumykov <kha...@google.com> > > Why is this needed? I dislike changes that don't fix anything. The function has no more users left after patch 1, so why keep it bitrotting? -- Johannes Thumshirn Storage jthumsh...@sus