Re: [PATCH] open-iscsi-dont-call-configure.patch

2011-08-17 Thread Mike Christie
On 08/17/2011 09:14 AM, Foo Bar wrote:
 Hi List,
 
 the configure is not needed.
 
 --- open-iscsi-2.0-872.orig/Makefile
 +++ open-iscsi-2.0-872/Makefile
 @@ -27,7 +27,7 @@ IFACEFILES = etc/iface.example
  all: user kernel
 
  user: ;
 -   cd utils/open-isns; ./configure; $(MAKE)
 +   cd utils/open-isns; $(MAKE)

This does not apply because there is a ./configure --with-security=no on
that line. The no security is there because for isns we are not using
any of that functionality so to void having to bring in openssl it is off.

-- 
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com.
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/open-iscsi?hl=en.



Re: [PATCH] open-iscsi-dont-call-configure.patch

2011-08-17 Thread Mike Christie
On 08/17/2011 05:39 PM, Mike Christie wrote:
 On 08/17/2011 09:14 AM, Foo Bar wrote:
 Hi List,

 the configure is not needed.

 --- open-iscsi-2.0-872.orig/Makefile
 +++ open-iscsi-2.0-872/Makefile
 @@ -27,7 +27,7 @@ IFACEFILES = etc/iface.example
  all: user kernel

  user: ;
 -   cd utils/open-isns; ./configure; $(MAKE)
 +   cd utils/open-isns; $(MAKE)
 
 This does not apply because there is a ./configure --with-security=no on
 that line. The no security is there because for isns we are not using
 any of that functionality so to void having to bring in openssl it is off.

Hey,

Also, if you are going to be sending a lot of patches then you should
try to make them against the git tree:

git clone git://git.kernel.org/pub/scm/linux/kernel/git/mnc/open-iscsi.git


But yeah in general the building of open-isns is nasty so any fixes are
appreciated. One day I would like to spit the open-isns into just a lib
package or just drop it for a more simple isns lib.

-- 
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com.
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/open-iscsi?hl=en.