Re: [PATCH 08/16] BNX2I: Added mutex lock protection to conn_get_param

2010-11-18 Thread Eddie Wai
On Wed, 2010-11-17 at 19:27 -0800, Mike Christie wrote: > On 11/10/2010 05:04 PM, Eddie Wai wrote: > > - return iscsi_conn_get_param(cls_conn, param, buf); > > + len = iscsi_conn_get_param(cls_conn, param, buf); > > + if (len == -ENOSYS) > > + len =

Re: [PATCH 08/16] BNX2I: Added mutex lock protection to conn_get_param

2010-11-17 Thread Mike Christie
On 11/10/2010 05:04 PM, Eddie Wai wrote: - return iscsi_conn_get_param(cls_conn, param, buf); + len = iscsi_conn_get_param(cls_conn, param, buf); + if (len == -ENOSYS) + len = 0; Why are you returning 0 here? -- You received this

[PATCH 08/16] BNX2I: Added mutex lock protection to conn_get_param

2010-11-10 Thread Eddie Wai
Added net_dev mutex lock protection before accessing the csk parameters. Signed-off-by: Eddie Wai Reviewed-by: Benjamin Li --- drivers/scsi/bnx2i/bnx2i_iscsi.c | 17 + 1 files changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/sc