Re: [PATCH 1/2] open-iscsi: Makefile: Don't build out-of-tree Kernel modules by default

[Mike Christie]

Boaz Harrosh wrote:
 
 Separate out the build of kernel: and user: targets.
 Let all: depend on user: only, though making kernel builds
 optional.
 

I like what the patches are doing by warning the user and fixing up the 
output, but could we just switch up the default? I think kernel 
developers are going to like what you did (I do), but I do not think 
that is what users do most of the time.

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~--~~~~--~~--~--~---

[PATCH 1/2] open-iscsi: Makefile: Don't build out-of-tree Kernel modules by default

[Boaz Harrosh]

Separate out the build of kernel: and user: targets.
Let all: depend on user: only, though making kernel builds
optional.

[Mike please revisit the @echo output if we need anything added?]

Signed-off-by: Boaz Harrosh bharr...@panasas.com
---
 Makefile |   26 +++---
 1 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/Makefile b/Makefile
index 9578697..a6d2b88 100644
--- a/Makefile
+++ b/Makefile
@@ -24,27 +24,31 @@ IFACEFILES = etc/iface.example
 # using '$(MAKE)' instead of just 'make' allows make to run in parallel
 # over multiple makefile.
 
-all:
+all: user
+
+user: ;
$(MAKE) -C utils/fwparam_ibft
$(MAKE) -C usr
-   $(MAKE) -C kernel
$(MAKE) -C utils
@echo
@echo Compilation complete Output file
@echo ---  
-   @echo Built iSCSI Open Interface module:   
kernel/scsi_transport_iscsi.ko
-   @echo Built iSCSI library module:  kernel/libiscsi.ko
-   @echo Built iSCSI over TCP library module: kernel/iscsi_tcp.ko
-   @echo Built iSCSI over TCP kernel module:  kernel/iscsi_tcp.ko
@echo Built iSCSI daemon:  usr/iscsid
@echo Built management application:usr/iscsiadm
@echo
-   @echo Read README file for detailed information.
+   @echo Use iSCSI modules from Distro kernel or run \make kernel\
+   @echo Read README file for detailed information.
 
-user:
-   $(MAKE) -C utils/fwparam_ibft
-   $(MAKE) -C utils
-   $(MAKE) -C usr
+kernel: force
+   $(MAKE) -C kernel
+   @echo Kernel Compilation complete  Output file
+   @echo ---  
+   @echo Built iSCSI Open Interface module:   
kernel/scsi_transport_iscsi.ko
+   @echo Built iSCSI library module:  kernel/libiscsi.ko
+   @echo Built iSCSI over TCP library module: kernel/libiscsi_tcp.ko
+   @echo Built iSCSI over TCP kernel module:  kernel/iscsi_tcp.ko
+
+force: ;
 
 clean:
$(MAKE) -C utils/fwparam_ibft clean
-- 
1.6.0.1



--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~--~~~~--~~--~--~---