Re: [PATCH 1/5] BNX2I - Add 5771E device support to bnx2i driver
On Wed, 2009-12-09 at 20:45 -0600, Mike Christie wrote: Reviewed-by: Mike Christie micha...@cs.wisc.edu But not by checkpatch: ERROR: trailing whitespace #23: FILE: drivers/scsi/bnx2i/bnx2i_init.c:90: +^I^Iprintk(KERN_ALERT bnx2i: unknown device, 0x%x\n, $ total: 1 errors, 0 warnings, 13 lines checked I've fixed it up. And the several other whitespace problems in the rest of the patch set. James -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-is...@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: [PATCH 1/5] BNX2I - Add 5771E device support to bnx2i driver
On Thu, 2009-12-10 at 07:43 -0800, James Bottomley wrote: On Wed, 2009-12-09 at 20:45 -0600, Mike Christie wrote: Reviewed-by: Mike Christie micha...@cs.wisc.edu But not by checkpatch: ERROR: trailing whitespace #23: FILE: drivers/scsi/bnx2i/bnx2i_init.c:90: +^I^Iprintk(KERN_ALERT bnx2i: unknown device, 0x%x\n, $ total: 1 errors, 0 warnings, 13 lines checked I've fixed it up. And the several other whitespace problems in the rest of the patch set. Thanks James. In future will make sure not to repeat the slip-up. Thanks again. James -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-is...@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: [PATCH 1/5] BNX2I - Add 5771E device support to bnx2i driver
Anil Veerabhadrappa wrote: * Add code to enumerate 5771E device Signed-off-by: Anil Veerabhadrappa ani...@broadcom.com --- drivers/scsi/bnx2i/bnx2i_init.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c index 0c4210d..3c46458 100644 --- a/drivers/scsi/bnx2i/bnx2i_init.c +++ b/drivers/scsi/bnx2i/bnx2i_init.c @@ -83,8 +83,12 @@ void bnx2i_identify_device(struct bnx2i_hba *hba) set_bit(BNX2I_NX2_DEV_5709, hba-cnic_dev_type); hba-mail_queue_access = BNX2I_MQ_BIN_MODE; } else if (hba-pci_did == PCI_DEVICE_ID_NX2_57710 || -hba-pci_did == PCI_DEVICE_ID_NX2_57711) +hba-pci_did == PCI_DEVICE_ID_NX2_57711 || +hba-pci_did == PCI_DEVICE_ID_NX2_57711E) set_bit(BNX2I_NX2_DEV_57710, hba-cnic_dev_type); + else + printk(KERN_ALERT bnx2i: unknown device, 0x%x\n, + hba-pci_did); } Ok. Reviewed-by: Mike Christie micha...@cs.wisc.edu -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-is...@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
[PATCH 1/5] BNX2I - Add 5771E device support to bnx2i driver
* Add code to enumerate 5771E device Signed-off-by: Anil Veerabhadrappa ani...@broadcom.com --- drivers/scsi/bnx2i/bnx2i_init.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c index 0c4210d..3c46458 100644 --- a/drivers/scsi/bnx2i/bnx2i_init.c +++ b/drivers/scsi/bnx2i/bnx2i_init.c @@ -83,8 +83,12 @@ void bnx2i_identify_device(struct bnx2i_hba *hba) set_bit(BNX2I_NX2_DEV_5709, hba-cnic_dev_type); hba-mail_queue_access = BNX2I_MQ_BIN_MODE; } else if (hba-pci_did == PCI_DEVICE_ID_NX2_57710 || - hba-pci_did == PCI_DEVICE_ID_NX2_57711) + hba-pci_did == PCI_DEVICE_ID_NX2_57711 || + hba-pci_did == PCI_DEVICE_ID_NX2_57711E) set_bit(BNX2I_NX2_DEV_57710, hba-cnic_dev_type); + else + printk(KERN_ALERT bnx2i: unknown device, 0x%x\n, + hba-pci_did); } -- 1.6.5.1 -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-is...@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
