Re: [PATCH 5/5] libiscsi: Flush workqueue before suspend

2009-08-10 Thread Hannes Reinecke
Mike Christie wrote: On 08/07/2009 05:27 AM, Hannes Reinecke wrote: We should be flushing the workqueue before setting the suspend bit. If we don't a LU Reset might kill commands which are already in the queue and waiting to be send, causing the target to barf. What do you mean here? What

[PATCH 5/5] libiscsi: Flush workqueue before suspend

2009-08-07 Thread Hannes Reinecke
We should be flushing the workqueue before setting the suspend bit. If we don't a LU Reset might kill commands which are already in the queue and waiting to be send, causing the target to barf. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/libiscsi.c |2 +- 1 files changed,

Re: [PATCH 5/5] libiscsi: Flush workqueue before suspend

2009-08-07 Thread Mike Christie
On 08/07/2009 05:27 AM, Hannes Reinecke wrote: We should be flushing the workqueue before setting the suspend bit. If we don't a LU Reset might kill commands which are already in the queue and waiting to be send, causing the target to barf. What do you mean here? What do you mean by barf?