Re: Antw: [PATCH 6/9] Add -Wno-unused-but-set-variable to some iscsiuio CFLAGS

2014-10-07 Thread Andy Grover 

On 10/06/2014 11:17 PM, Ulrich Windl wrote:

[...]

diff --git a/iscsiuio/src/uip/Makefile.am b/iscsiuio/src/uip/Makefile.am
index 16170d7..d728c8e 100644
--- a/iscsiuio/src/uip/Makefile.am
+++ b/iscsiuio/src/uip/Makefile.am
@@ -2,7 +2,8 @@ AM_CFLAGS = -I${top_srcdir}/src/unix\

[...]

+   -Wno-unused-but-set-variable


Does it make sense in the long term? I think you'll ignore more errors than you 
suppress invalid warnings...


Hmmm, ok.

I'll work on a v2 patchset that fixes these warnings, and also the 
mac_address size issue that you and Bart Van Assche pointed out.


Thanks!

Regards -- Andy

--
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Antw: [PATCH 6/9] Add -Wno-unused-but-set-variable to some iscsiuio CFLAGS

2014-10-06 Thread Ulrich Windl 
[...]
> diff --git a/iscsiuio/src/uip/Makefile.am b/iscsiuio/src/uip/Makefile.am
> index 16170d7..d728c8e 100644
> --- a/iscsiuio/src/uip/Makefile.am
> +++ b/iscsiuio/src/uip/Makefile.am
> @@ -2,7 +2,8 @@ AM_CFLAGS =   -I${top_srcdir}/src/unix\
[...]
> + -Wno-unused-but-set-variable

Does it make sense in the long term? I think you'll ignore more errors than you 
suppress invalid warnings...

Regards,
Ulrich


-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

[PATCH 6/9] Add -Wno-unused-but-set-variable to some iscsiuio CFLAGS

2014-10-06 Thread Andy Grover 
There are a fair number of warnings generated by the unused-but-set
warning in recent versions of GCC. These sometimes are there for
completeness and are not harmful, so a better choice may be to just silence
the warnings.

Signed-off-by: Andy Grover 
---
 iscsiuio/src/uip/Makefile.am   | 3 ++-
 iscsiuio/src/unix/Makefile.am  | 3 ++-
 iscsiuio/src/unix/libs/Makefile.am | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/iscsiuio/src/uip/Makefile.am b/iscsiuio/src/uip/Makefile.am
index 16170d7..d728c8e 100644
--- a/iscsiuio/src/uip/Makefile.am
+++ b/iscsiuio/src/uip/Makefile.am
@@ -2,7 +2,8 @@ AM_CFLAGS = -I${top_srcdir}/src/unix\
-I${top_srcdir}/src/apps/dhcpc  \
-I${top_srcdir}/src/apps/brcm-iscsi \
-I${top_srcdir}/../include  \
-   -I${top_srcdir}/../usr
+   -I${top_srcdir}/../usr  \
+   -Wno-unused-but-set-variable
 
 noinst_LIBRARIES = lib_iscsi_uip.a
 
diff --git a/iscsiuio/src/unix/Makefile.am b/iscsiuio/src/unix/Makefile.am
index 898691d..628c5fc 100644
--- a/iscsiuio/src/unix/Makefile.am
+++ b/iscsiuio/src/unix/Makefile.am
@@ -5,7 +5,8 @@ AM_CFLAGS = -I${top_srcdir}/src/uip \
   -I${top_srcdir}/src/apps/dhcpc   \
   -I${top_srcdir}/src/unix/libs\
   -I${top_srcdir}/../include   \
-  -I${top_srcdir}/../usr
+  -I${top_srcdir}/../usr   \
+  -Wno-unused-but-set-variable
 
 sbin_PROGRAMS = iscsiuio
 
diff --git a/iscsiuio/src/unix/libs/Makefile.am 
b/iscsiuio/src/unix/libs/Makefile.am
index 890415f..28a724f 100644
--- a/iscsiuio/src/unix/libs/Makefile.am
+++ b/iscsiuio/src/unix/libs/Makefile.am
@@ -3,7 +3,8 @@ AM_CFLAGS = -I${top_srcdir}/src/uip \
   -I${top_srcdir}/src/unix/libs\
-I${top_srcdir}/src/apps/dhcpc  \
-I${top_srcdir}/../include  \
-   -I${top_srcdir}/../usr
+   -I${top_srcdir}/../usr  \
+  -Wno-unused-but-set-variable
 
 noinst_LIBRARIES = lib_iscsiuio_hw_cnic.a
 
-- 
1.9.3

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.