Re: [PATCH untested] iscsi_tcp: Neat picking on code to make it more clear

2008-12-10 Thread Boaz Harrosh
Mike Christie wrote: Boaz Harrosh wrote: A buffer following an header, in case of a linear allocation can be get at by simply doing header_pointer + 1; I got this part, and it looks nicer. In any way below code loads a local pointer which is never used. I did not get this part. Do

Re: [PATCH untested] iscsi_tcp: Neat picking on code to make it more clear

2008-12-10 Thread Mike Christie
Boaz Harrosh wrote: Mike Christie wrote: Boaz Harrosh wrote: A buffer following an header, in case of a linear allocation can be get at by simply doing header_pointer + 1; I got this part, and it looks nicer. In any way below code loads a local pointer which is never used. I did not get

[PATCH untested] iscsi_tcp: Neat picking on code to make it more clear

2008-12-09 Thread Boaz Harrosh
A buffer following an header, in case of a linear allocation can be get at by simply doing header_pointer + 1; In any way below code loads a local pointer which is never used. Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] --- drivers/scsi/iscsi_tcp.c |2 +- 1 files changed, 1