Re: Is MaxOutstandingR2T hardcoded?
Erez Zilber wrote: > On Wed, Jan 7, 2009 at 8:34 PM, Mike Christie wrote: >> Erez Zilber wrote: >>> I noticed that if I change the value of >>> node.session.iscsi.MaxOutstandingR2T to some value > 1 (and the target >>> also supports a value higher than 1), it is still negotiated to '1'. I >>> saw that the login PDU itself contains 'MaxOutstandingR2T = 1'. >>> >>> I took a look at the code and found this in >>> login.c::add_params_normal_session: >>> >>> http://git.kernel.org/?p=linux/kernel/git/mnc/open-iscsi.git;a=blob;f=usr/login.c;h=02358703a423a1b09f578fd919e9245797a3c0b1;hb=HEAD#l802 >>> >>> Is it hardcoded on purpose? If yes, why? >>> >> Because the code only supports one. > > So, maybe it's a good idea to disable commands like "iscsiadm -m node > --op update -n node.session.iscsi.MaxOutstandingR2T -v some_val". > Yeah, send a patch. For some reason you can set tons of values that do not exists. I think it was partially from linux-iscsi and/or maybe from old code. In idbm.c just delete or comment out the unused ones (you could also actually then make the config structs smaller and remove those unused fields too). --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~---
Re: Is MaxOutstandingR2T hardcoded?
On Wed, Jan 7, 2009 at 8:34 PM, Mike Christie wrote: > > Erez Zilber wrote: >> I noticed that if I change the value of >> node.session.iscsi.MaxOutstandingR2T to some value > 1 (and the target >> also supports a value higher than 1), it is still negotiated to '1'. I >> saw that the login PDU itself contains 'MaxOutstandingR2T = 1'. >> >> I took a look at the code and found this in >> login.c::add_params_normal_session: >> >> http://git.kernel.org/?p=linux/kernel/git/mnc/open-iscsi.git;a=blob;f=usr/login.c;h=02358703a423a1b09f578fd919e9245797a3c0b1;hb=HEAD#l802 >> >> Is it hardcoded on purpose? If yes, why? >> > > Because the code only supports one. So, maybe it's a good idea to disable commands like "iscsiadm -m node --op update -n node.session.iscsi.MaxOutstandingR2T -v some_val". Erez --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~---
Re: Is MaxOutstandingR2T hardcoded?
Erez Zilber wrote: > I noticed that if I change the value of > node.session.iscsi.MaxOutstandingR2T to some value > 1 (and the target > also supports a value higher than 1), it is still negotiated to '1'. I > saw that the login PDU itself contains 'MaxOutstandingR2T = 1'. > > I took a look at the code and found this in > login.c::add_params_normal_session: > > http://git.kernel.org/?p=linux/kernel/git/mnc/open-iscsi.git;a=blob;f=usr/login.c;h=02358703a423a1b09f578fd919e9245797a3c0b1;hb=HEAD#l802 > > Is it hardcoded on purpose? If yes, why? > Because the code only supports one. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~---
Is MaxOutstandingR2T hardcoded?
I noticed that if I change the value of node.session.iscsi.MaxOutstandingR2T to some value > 1 (and the target also supports a value higher than 1), it is still negotiated to '1'. I saw that the login PDU itself contains 'MaxOutstandingR2T = 1'. I took a look at the code and found this in login.c::add_params_normal_session: http://git.kernel.org/?p=linux/kernel/git/mnc/open-iscsi.git;a=blob;f=usr/login.c;h=02358703a423a1b09f578fd919e9245797a3c0b1;hb=HEAD#l802 Is it hardcoded on purpose? If yes, why? Thanks, Erez --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~---