Re: Need Code Understanding

2017-02-16 Thread Chris Leech
The code in ioctl.c isn't actually used or built at all.  Thanks for reminding 
me to clean this up.  The project at one point was planning on supporting a 
FreeBSD kernel initiator as well, and ioctl.c is a remnant of that.

The code that's actually used to do the iscsid-to-kernel messaging is in 
netlink.c

- Chris

- Original Message -
> Hey
> 
> Referring to the code in file *ioctl.c*
> *Function: ctldev_open*
> The function callocs ioctl_sendbuf, ioctl_recvbuf, pdu_sendbuf but those 3
> parameters are not being used anywhere.
> Moreover the function returns *ctrl_fd*, but the variable is never set in
> the complete file.
> All those 4 above said variables are static in nature so cannot be used in
> any other file.
> Any insight would be good.
> 
> Thanks
> Lokesh
> 
> --
> You received this message because you are subscribed to the Google Groups
> "open-iscsi" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to open-iscsi+unsubscr...@googlegroups.com.
> To post to this group, send email to open-iscsi@googlegroups.com.
> Visit this group at https://groups.google.com/group/open-iscsi.
> For more options, visit https://groups.google.com/d/optout.
> 

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.


Need Code Understanding

2017-02-16 Thread lokesh arora
Hey

Referring to the code in file *ioctl.c*
*Function: ctldev_open*
The function callocs ioctl_sendbuf, ioctl_recvbuf, pdu_sendbuf but those 3
parameters are not being used anywhere.
Moreover the function returns *ctrl_fd*, but the variable is never set in
the complete file.
All those 4 above said variables are static in nature so cannot be used in
any other file.
Any insight would be good.

Thanks
Lokesh

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.