Re: [PATCH] Build system: sort object file lists

2016-02-18 Thread The Lee-Man 
On Saturday, February 13, 2016 at 3:30:13 PM UTC-8, Mike Christie wrote:

> >Lee and Chris, 
> >
> >The patch seems fine to me. It will not break SUSE or Red Hat build 
> >stuff will it? 
>

I have no objection. I personally prefer Makefile targets to be explicitly 
listed in the Make file, in which case they build would also be repeatable. 
But sorting the wildcard-filled file list is fine with me.

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Re: [PATCH] Build system: sort object file lists

2016-02-15 Thread Chris Leech 
On Sat, Feb 13, 2016 at 05:30:03PM -0600, Mike Christie wrote:
> On 02/12/2016 06:05 PM, Christian Seiler wrote:
> > Hi,
> > 
> > Debian is currently working on making the entire archive build
> > reproducibly.  is a good
> > resource describing the motivation behind this effort.
> > 
> > There was one problem that was found in the open-iscsi package
> > build system that prevented builds from being reproducible:
> > the list of object files generated by the wildcard Makefile
> > function are not in a deterministic order, causing changes in
> > the output depending on the order in the underlying filesystem.
> > 
> > I've attached a patch against the current git master that
> > sorts the list of object files within the Makefile, making the
> > order deterministic and allowing reproducible builds to be
> > made. See also:
> > 
> > 
> > It would be great if you could apply this patch upstream, so we
> > don't have to carry it in Debian.
> > 
> 
> Lee and Chris,
> 
> The patch seems fine to me. It will not break SUSE or Red Hat build
> stuff will it?

Looks good to me, I don't see it causing any problems.

- Chris

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Re: [PATCH] Build system: sort object file lists

2016-02-13 Thread Mike Christie 
On 02/12/2016 06:05 PM, Christian Seiler wrote:
> Hi,
> 
> Debian is currently working on making the entire archive build
> reproducibly.  is a good
> resource describing the motivation behind this effort.
> 
> There was one problem that was found in the open-iscsi package
> build system that prevented builds from being reproducible:
> the list of object files generated by the wildcard Makefile
> function are not in a deterministic order, causing changes in
> the output depending on the order in the underlying filesystem.
> 
> I've attached a patch against the current git master that
> sorts the list of object files within the Makefile, making the
> order deterministic and allowing reproducible builds to be
> made. See also:
> 
> 
> It would be great if you could apply this patch upstream, so we
> don't have to carry it in Debian.
> 

Lee and Chris,

The patch seems fine to me. It will not break SUSE or Red Hat build
stuff will it?


-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.