Re: [PATCH] Divide node parameters into 3 categories

2008-06-01 Thread Mike Christie
Eli Dorfman wrote: Doron Shoham wrote: Hi Mike, Are you ok with this patch? I think so. There was just some minor things I was going to fix when I merged it . For exmaples the timer values are not picked up right away so they need to be attr deffered. I am not going to merge it for the

Re: [PATCH] Divide node parameters into 3 categories

2008-04-13 Thread Doron Shoham
Doron Shoham wrote: Divide node parameters into 3 categories: a. Immutable - properties that are not allowed to change at all. b. Immediate - properties that are allowed to change and take effect immediately. c. Deferred - properties that are allowed to be changed only while

Re: [PATCH] Divide node parameters into 3 categories

2008-04-06 Thread Doron Shoham
Add -f flag (force) when changing node parameters that are defined as ATTR_DEFERRED. When using this flag, changing of ATTR_DEFERRED parameter while in active session can take place. The change itself will take effect only in the next session. A warning message is displayed. Signed-off-by:

Re: [PATCH] Divide node parameters into 3 categories

2008-04-01 Thread Mike Christie
Doron Shoham wrote: Mike Christie wrote: Doron Shoham wrote: Mike Christie wrote: Doron Shoham wrote: Divide node parameters into 3 categories: a. Immutable - properties that are not allowed to change at all. b. Immediate - properties that are allowed to change and take effect

Re: [PATCH] Divide node parameters into 3 categories

2008-03-31 Thread Mike Christie
Doron Shoham wrote: Mike Christie wrote: Doron Shoham wrote: Divide node parameters into 3 categories: a. Immutable - properties that are not allowed to change at all. b. Immediate - properties that are allowed to change and take effect immediately. c. Deferred - properties that are

Re: [PATCH] Divide node parameters into 3 categories

2008-03-31 Thread Mike Christie
Mike Christie wrote: We can make it so the transport type is not changable while logged in. We do that today already in the git tree. Oh yeah, we were probably both right :) iface.transport_name is checked, but node.transport_name is not, so like we said before we need to update

Re: [PATCH] Divide node parameters into 3 categories

2008-03-29 Thread Doron Shoham
Mike Christie wrote: Doron Shoham wrote: Divide node parameters into 3 categories: a. Immutable - properties that are not allowed to change at all. b. Immediate - properties that are allowed to change and take effect immediately. c. Deferred - properties that are allowed to change but

Re: [PATCH] Divide node parameters into 3 categories

2008-03-26 Thread Mike Christie
Doron Shoham wrote: Divide node parameters into 3 categories: a. Immutable - properties that are not allowed to change at all. b. Immediate - properties that are allowed to change and take effect immediately. c. Deferred - properties that are allowed to change but will take effect

Re: [PATCH] Divide node parameters into 3 categories

2008-03-26 Thread Mike Christie
Doron Shoham wrote: Divide node parameters into 3 categories: a. Immutable - properties that are not allowed to change at all. b. Immediate - properties that are allowed to change and take effect immediately. c. Deferred - properties that are allowed to change but will take effect