Re: [PATCH] iscsi: fall back to sendmsg for slab pages

2019-03-10 Thread Lee Duncan
On 3/6/19 3:33 AM, Vasily Averin wrote: > James, Martin, > noone replied 2 weeks, > could you please pick up this patch? > > According to Network guru sendpage must not be called for Slab objects. > Unfortunately this happen in real life, for example when XFS send metadata > via network block dev

Re: [PATCH] iscsi: fall back to sendmsg for slab pages

2019-03-06 Thread Martin K. Petersen
Vasily, > In "XFS over network block device" scenario XFS can create IO requests > with slab-based XFS metadata. During processing such requests > tcp_sendpage() can merge skb fragments with neighbour slab objects. Applied to 5.1/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Eng

Re: [PATCH] iscsi: fall back to sendmsg for slab pages

2019-03-06 Thread Vasily Averin
James, Martin, noone replied 2 weeks, could you please pick up this patch? According to Network guru sendpage must not be called for Slab objects. Unfortunately this happen in real life, for example when XFS send metadata via network block device. Some of such cases -- drbd and ceph -- already ha

Re: [PATCH] iscsi: fall back to sendmsg for slab pages

2019-03-06 Thread Chris Leech
On Thu, Feb 21, 2019 at 06:23:17PM +0300, Vasily Averin wrote: > In "XFS over network block device" scenario XFS can create IO requests > with slab-based XFS metadata. During processing such requests > tcp_sendpage() can merge skb fragments with neighbour slab objects. > > If receiving side is loc

Re: [PATCH] iscsi: fall back to sendmsg for slab pages

2019-03-06 Thread Martin K. Petersen
Vasily, > James, Martin, noone replied 2 weeks, could you please pick up this > patch? No objections from me wrt. to the change. However, I am awaiting a review from the iSCSI maintainers Lee and Chris. -- Martin K. Petersen Oracle Linux Engineering -- You received this message because