Re: [PATCH] libiscsi: avoid unnecessary multiple NULL assignments

2013-04-08 Thread Masatake YAMATO
On 03/21/2013 08:56 PM, Masatake YAMATO wrote: Did it just not get picked up there by the scsi maintainer? Yes. Doh. Could you pick up this patch? Yes. Sorry about that. I will send it with my next feature window update since this is not a bug fix. Could you cc me when you

Re: [PATCH] libiscsi: avoid unnecessary multiple NULL assignments

2013-04-08 Thread Mike Christie
On 04/08/2013 03:05 AM, Masatake YAMATO wrote: On 03/21/2013 08:56 PM, Masatake YAMATO wrote: Did it just not get picked up there by the scsi maintainer? Yes. Doh. Could you pick up this patch? Yes. Sorry about that. I will send it with my next feature window update since this is not

Re: [PATCH] libiscsi: avoid unnecessary multiple NULL assignments

2013-03-21 Thread Mike Christie
On 03/19/2013 05:52 AM, Masatake YAMATO wrote: In iscsi_free_task, NULL is assigned to task-sc twice: before and after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded with session-lock, so multiple NULL assignments cause no trouble. But people reading the source code may be

Re: [PATCH] libiscsi: avoid unnecessary multiple NULL assignments

2013-03-21 Thread Masatake YAMATO
On 03/19/2013 05:52 AM, Masatake YAMATO wrote: In iscsi_free_task, NULL is assigned to task-sc twice: before and after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded with session-lock, so multiple NULL assignments cause no trouble. But people reading the source code may be

Re: [PATCH] libiscsi: avoid unnecessary multiple NULL assignments

2013-03-21 Thread Mike Christie
On 03/21/2013 08:56 PM, Masatake YAMATO wrote: Did it just not get picked up there by the scsi maintainer? Yes. Doh. Could you pick up this patch? Yes. Sorry about that. I will send it with my next feature window update since this is not a bug fix. -- You received this message

Re: [PATCH] libiscsi: avoid unnecessary multiple NULL assignments

2013-03-21 Thread Masatake YAMATO
On 03/21/2013 08:56 PM, Masatake YAMATO wrote: Did it just not get picked up there by the scsi maintainer? Yes. Doh. Could you pick up this patch? Yes. Sorry about that. I will send it with my next feature window update since this is not a bug fix. Thank you. Masatake YAMATO

Re: [PATCH] libiscsi: avoid unnecessary multiple NULL assignments

2012-08-12 Thread Michael Christie
Replacing linux-scsi list with linux-kernel. On Aug 12, 2012, at 9:15 AM, Masatake YAMATO yam...@redhat.com wrote: In iscsi_free_task, NULL is assigned to task-sc twice: before and after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded with session-lock, so multiple NULL