Re: [PATCH 0/3] open-isns: prepare for external use by open-iscsi

2015-07-14 Thread Mike Christie
On 07/13/2015 08:04 PM, The Lee-Man wrote:
> If there are no objections I will commit these changes. Then I'll submit
> a set of patches for open-iscsi to use this package instead of it's
> internal copy of it.
> 
> Sound good Mike?
> 

Thanks for taking on open-isns! Yes, sounds good to me.


> On Monday, July 13, 2015 at 2:57:45 PM UTC-7, The Lee-Man wrote:
> 
> From: Lee Duncan mailto:ldun...@suse.com>>
> 
> This group of patches is for open-isns, and the current procedure for
> changes to open-isns is to share them on the open-iscsi mailing list.
> 
> The goal of these patches is to make open-isns a stand-alone package
> that can be used by other (like open-iscsi). This way clients don't
> have to have their own (possibly stale) copies of these files.
> 
> NOTE: there are NO FUNCTIONAL CHANGES here, just:
> * moving some inclue files locally to include/libisns directory
> * changing all users of include files to know new location
> * Adding "install_lib" and "install_hdrs" Makefile targets
> 
> This has been tested with open-iscsn and seems to work.
> 
> Lee Duncan (3):
>   Move public inlcude files to 
>   Make one more include file public.
>   Add test binaries as 'make clean' targets.
> 
>  Makefile.in  |  27 +-
>  attrs.c  |   6 +-
>  attrs.h  | 262 -
>  authblock.c  |   8 +-
>  bitvector.c  |   4 +-
>  buffer.c |   4 +-
>  buffer.h | 141 -
>  callback.c   |   6 +-
>  client.c |   4 +-
>  config.c |   6 +-
>  db-file.c|   6 +-
>  db-policy.c  |   4 +-
>  db.c |   4 +-
>  db.h |   2 +-
>  dd.c |   8 +-
>  deregister.c |   8 +-
>  domain.c |   4 +-
>  entity.c |   4 +-
>  error.c  |   2 +-
>  esi.c|   8 +-
>  export.c |   8 +-
>  getnext.c|   8 +-
>  include/libisns/attrs.h  | 262 +
>  include/libisns/buffer.h | 141 +
>  include/libisns/isns-proto.h | 259 +
>  include/libisns/isns.h   | 676
> +++
>  include/libisns/message.h| 196 +
>  include/libisns/paths.h  |  24 ++
>  include/libisns/source.h |  32 ++
>  include/libisns/types.h  |  57 
>  include/libisns/util.h   | 288 ++
>  isns-proto.h | 259 -
>  isns.h   | 676
> ---
>  isnsadm.c|   8 +-
>  isnsd.c  |   6 +-
>  isnsdd.c |  10 +-
>  local.c  |  12 +-
>  logging.c|   2 +-
>  mdebug.c |   2 +-
>  message.c|   8 +-
>  message.h| 196 -
>  objects.c|   8 +-
>  objects.h|   4 +-
>  parser.c |   2 +-
>  paths.h  |  24 --
>  pidfile.c|   2 +-
>  pki.c|   4 +-
>  policy.c |   6 +-
>  portal-group.c   |   6 +-
>  query.c  |   8 +-
>  register.c   |   8 +-
>  relation.c   |   4 +-
>  scn.c|   8 +-
>  scope.c  |   8 +-
>  security.c   |   6 +-
>  security.h   |   4 +-
>  server.c |   6 +-
>  simple.c |   8 +-
>  slp.c|   4 +-
>  socket.c |   6 +-
>  socket.h |   6 +-
>  source.h |  32 --
>  storage-node.c   |   4 +-
>  sysdep-unix.c|   4 +-
>  tags.c   |   6 +-
>  tests/pauw1.c|   8 +-
>  tests/pauw2.c|   8 +-
>  tests/pauw3.c|   8 +-
>  tests/pauw4.c|   8 +-
>  timer.c  |   4 +-
>  types.h  |  57 
>  util.c   |   2 +-
>  util.h   | 288 --
>  vendor.c |   6 +-
>  vendor.h |   2 +-
>  75 files changed, 2121 insertions(+), 2096 deletions(-)
>  delete mode 100644 attrs.h
>  delete mode 100644 b

Re: [PATCH 0/3] open-isns: prepare for external use by open-iscsi

2015-07-13 Thread The Lee-Man
If there are no objections I will commit these changes. Then I'll submit a 
set of patches for open-iscsi to use this package instead of it's internal 
copy of it.

Sound good Mike?

On Monday, July 13, 2015 at 2:57:45 PM UTC-7, The Lee-Man wrote:
>
> From: Lee Duncan  
>
> This group of patches is for open-isns, and the current procedure for 
> changes to open-isns is to share them on the open-iscsi mailing list. 
>
> The goal of these patches is to make open-isns a stand-alone package 
> that can be used by other (like open-iscsi). This way clients don't 
> have to have their own (possibly stale) copies of these files. 
>
> NOTE: there are NO FUNCTIONAL CHANGES here, just: 
> * moving some inclue files locally to include/libisns directory 
> * changing all users of include files to know new location 
> * Adding "install_lib" and "install_hdrs" Makefile targets 
>
> This has been tested with open-iscsn and seems to work. 
>
> Lee Duncan (3): 
>   Move public inlcude files to  
>   Make one more include file public. 
>   Add test binaries as 'make clean' targets. 
>
>  Makefile.in  |  27 +- 
>  attrs.c  |   6 +- 
>  attrs.h  | 262 - 
>  authblock.c  |   8 +- 
>  bitvector.c  |   4 +- 
>  buffer.c |   4 +- 
>  buffer.h | 141 - 
>  callback.c   |   6 +- 
>  client.c |   4 +- 
>  config.c |   6 +- 
>  db-file.c|   6 +- 
>  db-policy.c  |   4 +- 
>  db.c |   4 +- 
>  db.h |   2 +- 
>  dd.c |   8 +- 
>  deregister.c |   8 +- 
>  domain.c |   4 +- 
>  entity.c |   4 +- 
>  error.c  |   2 +- 
>  esi.c|   8 +- 
>  export.c |   8 +- 
>  getnext.c|   8 +- 
>  include/libisns/attrs.h  | 262 + 
>  include/libisns/buffer.h | 141 + 
>  include/libisns/isns-proto.h | 259 + 
>  include/libisns/isns.h   | 676 
> +++ 
>  include/libisns/message.h| 196 + 
>  include/libisns/paths.h  |  24 ++ 
>  include/libisns/source.h |  32 ++ 
>  include/libisns/types.h  |  57  
>  include/libisns/util.h   | 288 ++ 
>  isns-proto.h | 259 - 
>  isns.h   | 676 
> --- 
>  isnsadm.c|   8 +- 
>  isnsd.c  |   6 +- 
>  isnsdd.c |  10 +- 
>  local.c  |  12 +- 
>  logging.c|   2 +- 
>  mdebug.c |   2 +- 
>  message.c|   8 +- 
>  message.h| 196 - 
>  objects.c|   8 +- 
>  objects.h|   4 +- 
>  parser.c |   2 +- 
>  paths.h  |  24 -- 
>  pidfile.c|   2 +- 
>  pki.c|   4 +- 
>  policy.c |   6 +- 
>  portal-group.c   |   6 +- 
>  query.c  |   8 +- 
>  register.c   |   8 +- 
>  relation.c   |   4 +- 
>  scn.c|   8 +- 
>  scope.c  |   8 +- 
>  security.c   |   6 +- 
>  security.h   |   4 +- 
>  server.c |   6 +- 
>  simple.c |   8 +- 
>  slp.c|   4 +- 
>  socket.c |   6 +- 
>  socket.h |   6 +- 
>  source.h |  32 -- 
>  storage-node.c   |   4 +- 
>  sysdep-unix.c|   4 +- 
>  tags.c   |   6 +- 
>  tests/pauw1.c|   8 +- 
>  tests/pauw2.c|   8 +- 
>  tests/pauw3.c|   8 +- 
>  tests/pauw4.c|   8 +- 
>  timer.c  |   4 +- 
>  types.h  |  57  
>  util.c   |   2 +- 
>  util.h   | 288 -- 
>  vendor.c |   6 +- 
>  vendor.h |   2 +- 
>  75 files changed, 2121 insertions(+), 2096 deletions(-) 
>  delete mode 100644 attrs.h 
>  delete mode 100644 buffer.h 
>  create mode 100644 include/libisns/attrs.h 
>  create mode 100644 include/libisns/buffer.h 
>  create mode 100644 include/libisns/isns-proto.h 
>  create mode 100644 include/libisns/isns.h 
>  create mode 100644 include/libisns/message.h 
>  create mode 100644 include/libisns/paths.h 
>  create mode 100644 include/libisns/source.h 
>  create mode 100644 include/libisns/types.h 
>  create mode 100644 include/libisns/u