Re: [PATCH 02/11] qla4xxx: added IPv6 support.
Mike, Yes, IPV6 works for be2iscsi. One of our guys had set it up and we were able to do login etc. You mentioned that be2iscsi handling is incorrect, can you let me know the details -Jay _ From: Mike Christie [mailto:micha...@cs.wisc.edu] To: ravi.anand [mailto:ravi.an...@qlogic.com] Cc: James Bottomley [mailto:james.bottom...@suse.de], Linux-SCSI Mailing List [mailto:linux-s...@vger.kernel.org], Vikas Chaudhary [mailto:vikas.chaudh...@qlogic.com], open-iscsi [mailto:open-is...@googlegroups.com], Karen Xie [mailto:k...@chelsio.com], Jayamohan Kalickal [mailto:jayamoh...@serverengines.com] Sent: Tue, 06 Apr 2010 20:43:30 -0700 Subject: Re: [PATCH 02/11] qla4xxx: added IPv6 support. On 04/06/2010 05:21 AM, ravi.anand wrote: On Feb 1, 2010, at 10:15 AM, Mike Christie wrote: On 01/30/2010 12:28 AM, Ravi Anand wrote: + DEBUG2(dev_info(ha-pdev-dev, %s: DDB[%d] osIdx = %d + State %04x ConnErr %08x + NIPQUAD_FMT :%04d \%s\\n, Do you go down this path for ipv6 (looked like it did and did in other places)? NIPQUAD_FMT will not work, and we are trying to not use it NIPQUAD_FMT/NIPQUAD. See %pI4 use in qla4xxx_conn_get_param. There is also a %pI6 for ipv6. Also you need to update qla4xxx_conn_get_param and qla4xxx_host_get_param ip handling. While trying to address the IPV6 part for conn_get_param() and host_get_param(), we ran into the dilemma how to populate IPV4 and IPV6 address at the same time. Currently on our adapter IPV4 and IPV6 can be enabled at the same time and can be active. So we wanted to find out if for following param mask : ISCSI_HOST_PARAM_IPADDRESS should we just fill the buffer for IPV4 and IPV6 address or should we need define new param mask sepeartely for IPV6 ? Basically we will like to follow up with another patch to address this part on to of the patches which we have just pushed. Right now iscsi_tcp supports ipv4 and ipv6 for that param. I think people have been saying it might be easier to break it up into a ipv4 and ipv6 param. Karen, it seems like you are only supporting ipv4 right now. Any thoughts? Jay, it seems be2iscsi handling is incorrect. Is your driver supporting ipv6 right now? -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ___ This message, together with any attachment(s), contains confidential and proprietary information of ServerEngines Corporation and is intended only for the designated recipient(s) named above. Any unauthorized review, printing, retention, copying, disclosure or distribution is strictly prohibited. If you are not the intended recipient of this message, please immediately advise the sender by reply email message and delete all copies of this message and any attachment(s). Thank you. -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-is...@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: [PATCH 02/11] qla4xxx: added IPv6 support.
On 04/06/2010 10:43 PM, Mike Christie wrote: On 04/06/2010 05:21 AM, ravi.anand wrote: On Feb 1, 2010, at 10:15 AM, Mike Christie wrote: On 01/30/2010 12:28 AM, Ravi Anand wrote: + DEBUG2(dev_info(ha-pdev-dev, %s: DDB[%d] osIdx = %d + State %04x ConnErr %08x + NIPQUAD_FMT :%04d \%s\\n, Do you go down this path for ipv6 (looked like it did and did in other places)? NIPQUAD_FMT will not work, and we are trying to not use it NIPQUAD_FMT/NIPQUAD. See %pI4 use in qla4xxx_conn_get_param. There is also a %pI6 for ipv6. Also you need to update qla4xxx_conn_get_param and qla4xxx_host_get_param ip handling. While trying to address the IPV6 part for conn_get_param() and host_get_param(), we ran into the dilemma how to populate IPV4 and IPV6 address at the same time. Currently on our adapter IPV4 and IPV6 can be enabled at the same time and can be active. So we wanted to find out if for following param mask : ISCSI_HOST_PARAM_IPADDRESS should we just fill the buffer for IPV4 and IPV6 address or should we need define new param mask sepeartely for IPV6 ? Basically we will like to follow up with another patch to address this part on to of the patches which we have just pushed. Right now iscsi_tcp supports ipv4 and ipv6 for that param. I think people have been saying it might be easier to break it up into a ipv4 and ipv6 param. Karen, it seems like you are only supporting ipv4 right now. Any thoughts? Jay, it seems be2iscsi handling is incorrect. Is your driver supporting ipv6 right now? After looking at the code, I think I misunderstood what you needed. You want to have multiple ip addresses at the same time, right? be2iscsi needs the ability to support multiple ipv4 and/or ipv6 addresses at the same time. I would think other cards are going to need this feature one day too, so maybe we could make this a little more generic. Would having a ISCSI_HOST_PARAM_IPADDRESSES param where you can get N addresses work for all cases? For the netlink side we could just define the netlink msg to have a counter and some separator. And for bsg we could do something similar. To display this in sysfs I think it gets more complicated, I think we need to add a sysfs file for each address. And then actually I think we want a sysfs dir for each address, because do want to config other params for each address like a port or subnet mask or dns info, etc (each item would be a sysfs file in some dir)? Or what about vlans too? Some cards support multiple vlans, so would you want /sys/class/iscsi_host/host1 And then the tree under the host would be tree host1 # this one would be a vlan |-net_interface0 |-ip |-subnet |-vlan_idA |-net_interface1 |-ip |-subnet |-vlan_idB # no vlans but each interface has different ips |-net_interface2 |-ip |-subnet_mask |-net_interface3 |-ip |-subnet_mask -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-is...@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: [PATCH 02/11] qla4xxx: added IPv6 support.
On 04/07/2010 12:26 PM, Jayamohan Kalickal wrote: Mike, Yes, IPV6 works for be2iscsi. One of our guys had set it up and we were able to do login etc. You mentioned that be2iscsi handling is incorrect, can you let me know the details Do cat /sys/class/iscsi_host/hostX/ipaddress You will not get anything, because you set the iscsi_transport template bit to export this setting, but you did not handle it in the get host param callout. -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-is...@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: [PATCH 02/11] qla4xxx: added IPv6 support.
On 04/06/2010 05:21 AM, ravi.anand wrote: On Feb 1, 2010, at 10:15 AM, Mike Christie wrote: On 01/30/2010 12:28 AM, Ravi Anand wrote: + DEBUG2(dev_info(ha-pdev-dev, %s: DDB[%d] osIdx = %d + State %04x ConnErr %08x + NIPQUAD_FMT :%04d \%s\\n, Do you go down this path for ipv6 (looked like it did and did in other places)? NIPQUAD_FMT will not work, and we are trying to not use it NIPQUAD_FMT/NIPQUAD. See %pI4 use in qla4xxx_conn_get_param. There is also a %pI6 for ipv6. Also you need to update qla4xxx_conn_get_param and qla4xxx_host_get_param ip handling. While trying to address the IPV6 part for conn_get_param() and host_get_param(), we ran into the dilemma how to populate IPV4 and IPV6 address at the same time. Currently on our adapter IPV4 and IPV6 can be enabled at the same time and can be active. So we wanted to find out if for following param mask : ISCSI_HOST_PARAM_IPADDRESS should we just fill the buffer for IPV4 and IPV6 address or should we need define new param mask sepeartely for IPV6 ? Basically we will like to follow up with another patch to address this part on to of the patches which we have just pushed. Right now iscsi_tcp supports ipv4 and ipv6 for that param. I think people have been saying it might be easier to break it up into a ipv4 and ipv6 param. Karen, it seems like you are only supporting ipv4 right now. Any thoughts? Jay, it seems be2iscsi handling is incorrect. Is your driver supporting ipv6 right now? -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-is...@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
RE: [PATCH 02/11] qla4xxx: added IPv6 support.
Hi, Mike, Yeah, the cxgb3i does have the limitation of offloading ipv4 only. Would it be possible to have separate param for ipv4 and ipv6? Thanks, Karen -Original Message- From: Mike Christie [mailto:micha...@cs.wisc.edu] Sent: Tuesday, April 06, 2010 8:44 PM To: ravi.anand Cc: James Bottomley; Linux-SCSI Mailing List; Vikas Chaudhary; open-iscsi; Karen Xie; Jayamohan Kalickal Subject: Re: [PATCH 02/11] qla4xxx: added IPv6 support. On 04/06/2010 05:21 AM, ravi.anand wrote: On Feb 1, 2010, at 10:15 AM, Mike Christie wrote: On 01/30/2010 12:28 AM, Ravi Anand wrote: + DEBUG2(dev_info(ha-pdev-dev, %s: DDB[%d] osIdx = %d + State %04x ConnErr %08x + NIPQUAD_FMT :%04d \%s\\n, Do you go down this path for ipv6 (looked like it did and did in other places)? NIPQUAD_FMT will not work, and we are trying to not use it NIPQUAD_FMT/NIPQUAD. See %pI4 use in qla4xxx_conn_get_param. There is also a %pI6 for ipv6. Also you need to update qla4xxx_conn_get_param and qla4xxx_host_get_param ip handling. While trying to address the IPV6 part for conn_get_param() and host_get_param(), we ran into the dilemma how to populate IPV4 and IPV6 address at the same time. Currently on our adapter IPV4 and IPV6 can be enabled at the same time and can be active. So we wanted to find out if for following param mask : ISCSI_HOST_PARAM_IPADDRESS should we just fill the buffer for IPV4 and IPV6 address or should we need define new param mask sepeartely for IPV6 ? Basically we will like to follow up with another patch to address this part on to of the patches which we have just pushed. Right now iscsi_tcp supports ipv4 and ipv6 for that param. I think people have been saying it might be easier to break it up into a ipv4 and ipv6 param. Karen, it seems like you are only supporting ipv4 right now. Any thoughts? Jay, it seems be2iscsi handling is incorrect. Is your driver supporting ipv6 right now? -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-is...@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
