Re: [PATCH 2/2] cxgbi: get rid of gl_skb in cxgbi_ddp_info
On 01/07/2011 04:45 PM, k...@chelsio.com wrote: [PATCH 2/2] cxgbi: get rid of gl_skb in cxgbi_ddp_info. From: Karen Xiek...@chelsio.com Remove gl_skb from cxgbi_ddp_info as it is only used by cxgb3i. Signed-off-by: Karen Xiek...@chelsio.com Ok for now. Reviewed-by: Mike Christie micha...@cs.wisc.edu -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-is...@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: [PATCH 2/2] cxgbi: get rid of gl_skb in cxgbi_ddp_info
On 01/10/2011 11:52 AM, Karen Xie wrote: Hi, Mike, What I mean is even if cxgb3i maintains a pool of skbs (equivalent of gl_skbs). Once they are handed down to the network layer cxgb3 they will still be freed by the network driver (on the tx path). So hows does it work now? It seems ddp_alloc_gl_skb is called at device setup time, then when IO is queued/xmited we run ddp_set_map which allocates from gl_skbs. If when you transmit the IO, the driver frees the skb, how does gl_skb get replenished? -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-is...@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
RE: [PATCH 2/2] cxgbi: get rid of gl_skb in cxgbi_ddp_info
Yes, that's bug this patch is fixing too. The current implementation does not replenish the gl_skb after the initial allocation. I am working on an update which utilizing a pool of skbs, and those skbs would be used not only for the ddp setups (like the current gl_skb) but also for the connection management like the rx credit returns. So this skb pool will not reside in cxgbi_ddp_info, so still need to get rid of gl_skb. I guess this patch can be viewed as an interim fix. -Original Message- From: Mike Christie [mailto:micha...@cs.wisc.edu] Sent: Monday, January 10, 2011 11:57 AM To: Karen Xie Cc: open-iscsi@googlegroups.com; linux-s...@vger.kernel.org; james.bottom...@hansenpartnership.com Subject: Re: [PATCH 2/2] cxgbi: get rid of gl_skb in cxgbi_ddp_info On 01/10/2011 11:52 AM, Karen Xie wrote: Hi, Mike, What I mean is even if cxgb3i maintains a pool of skbs (equivalent of gl_skbs). Once they are handed down to the network layer cxgb3 they will still be freed by the network driver (on the tx path). So hows does it work now? It seems ddp_alloc_gl_skb is called at device setup time, then when IO is queued/xmited we run ddp_set_map which allocates from gl_skbs. If when you transmit the IO, the driver frees the skb, how does gl_skb get replenished? -- You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-is...@googlegroups.com. To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
Re: [PATCH 2/2] cxgbi: get rid of gl_skb in cxgbi_ddp_info
On 01/07/2011 04:45 PM, k...@chelsio.com wrote:
[PATCH 2/2] cxgbi: get rid of gl_skb in cxgbi_ddp_info.
From: Karen Xiek...@chelsio.com
Remove gl_skb from cxgbi_ddp_info as it is only used by cxgb3i.
Signed-off-by: Karen Xiek...@chelsio.com
---
drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 51 +---
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c |2 -
drivers/scsi/cxgbi/libcxgbi.c | 15 +--
drivers/scsi/cxgbi/libcxgbi.h |3 --
4 files changed, 8 insertions(+), 63 deletions(-)
diff --git a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
index a129a17..e2362b9 100644
--- a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
+++ b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
@@ -1108,10 +1108,11 @@ static int ddp_set_map(struct cxgbi_sock *csk, struct
cxgbi_pagepod_hdr *hdr,
csk, idx, npods, gl);
for (i = 0; i npods; i++, idx++, pm_addr += PPOD_SIZE) {
- struct sk_buff *skb = ddp-gl_skb[idx];
+ struct sk_buff *skb = alloc_wr(sizeof(struct ulp_mem_io) +
+ PPOD_SIZE, 0, GFP_ATOMIC);
I think you want to try to avoid lots of little GFP_ATOMIC allocations
in the main IO path, because it probably is bad for performance and
because they can fail and you can be stuck with no mem but other
allocations needing to write data out.
Did you want to just make each driver allocate a pool/map, then allocate
from that pool/map in these places (cxgb4i does a similar skb allocation
at these points right?)?
--
You received this message because you are subscribed to the Google Groups
open-iscsi group.
To post to this group, send email to open-is...@googlegroups.com.
To unsubscribe from this group, send email to
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/open-iscsi?hl=en.
Re: [PATCH 2/2] cxgbi: get rid of gl_skb in cxgbi_ddp_info
On 01/07/2011 05:42 PM, Mike Christie wrote:
On 01/07/2011 04:45 PM, k...@chelsio.com wrote:
[PATCH 2/2] cxgbi: get rid of gl_skb in cxgbi_ddp_info.
From: Karen Xiek...@chelsio.com
Remove gl_skb from cxgbi_ddp_info as it is only used by cxgb3i.
Signed-off-by: Karen Xiek...@chelsio.com
---
drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 51
+---
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 2 -
drivers/scsi/cxgbi/libcxgbi.c | 15 +--
drivers/scsi/cxgbi/libcxgbi.h | 3 --
4 files changed, 8 insertions(+), 63 deletions(-)
diff --git a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
index a129a17..e2362b9 100644
--- a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
+++ b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
@@ -1108,10 +1108,11 @@ static int ddp_set_map(struct cxgbi_sock *csk,
struct cxgbi_pagepod_hdr *hdr,
csk, idx, npods, gl);
for (i = 0; i npods; i++, idx++, pm_addr += PPOD_SIZE) {
- struct sk_buff *skb = ddp-gl_skb[idx];
+ struct sk_buff *skb = alloc_wr(sizeof(struct ulp_mem_io) +
+ PPOD_SIZE, 0, GFP_ATOMIC);
I think you want to try to avoid lots of little GFP_ATOMIC allocations
in the main IO path, because it probably is bad for performance and
because they can fail and you can be stuck with no mem but other
allocations needing to write data out.
Did you want to just make each driver allocate a pool/map, then allocate
from that pool/map in these places (cxgb4i does a similar skb allocation
at these points right?)?
Oh yeah, is the complication that the cxgb3i driver uses 1 size for the
objects but cxgb4i is variable?
--
You received this message because you are subscribed to the Google Groups
open-iscsi group.
To post to this group, send email to open-is...@googlegroups.com.
To unsubscribe from this group, send email to
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/open-iscsi?hl=en.
RE: [PATCH 2/2] cxgbi: get rid of gl_skb in cxgbi_ddp_info
Hi, Mike,
Yes, the message size is different between cxgb3i and cxgb4i. I am not
using the pool mainly because this is on the tx side and tx skb
recycling does not seem to be utilized much.
Karen
-Original Message-
From: Mike Christie [mailto:micha...@cs.wisc.edu]
Sent: Friday, January 07, 2011 3:48 PM
To: open-iscsi@googlegroups.com
Cc: Karen Xie; linux-s...@vger.kernel.org;
james.bottom...@hansenpartnership.com
Subject: Re: [PATCH 2/2] cxgbi: get rid of gl_skb in cxgbi_ddp_info
On 01/07/2011 05:42 PM, Mike Christie wrote:
On 01/07/2011 04:45 PM, k...@chelsio.com wrote:
[PATCH 2/2] cxgbi: get rid of gl_skb in cxgbi_ddp_info.
From: Karen Xiek...@chelsio.com
Remove gl_skb from cxgbi_ddp_info as it is only used by cxgb3i.
Signed-off-by: Karen Xiek...@chelsio.com
---
drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 51
+---
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 2 -
drivers/scsi/cxgbi/libcxgbi.c | 15 +--
drivers/scsi/cxgbi/libcxgbi.h | 3 --
4 files changed, 8 insertions(+), 63 deletions(-)
diff --git a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
index a129a17..e2362b9 100644
--- a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
+++ b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
@@ -1108,10 +1108,11 @@ static int ddp_set_map(struct cxgbi_sock
*csk,
struct cxgbi_pagepod_hdr *hdr,
csk, idx, npods, gl);
for (i = 0; i npods; i++, idx++, pm_addr += PPOD_SIZE) {
- struct sk_buff *skb = ddp-gl_skb[idx];
+ struct sk_buff *skb = alloc_wr(sizeof(struct ulp_mem_io) +
+ PPOD_SIZE, 0, GFP_ATOMIC);
I think you want to try to avoid lots of little GFP_ATOMIC allocations
in the main IO path, because it probably is bad for performance and
because they can fail and you can be stuck with no mem but other
allocations needing to write data out.
Did you want to just make each driver allocate a pool/map, then
allocate
from that pool/map in these places (cxgb4i does a similar skb
allocation
at these points right?)?
Oh yeah, is the complication that the cxgb3i driver uses 1 size for the
objects but cxgb4i is variable?
--
You received this message because you are subscribed to the Google Groups
open-iscsi group.
To post to this group, send email to open-is...@googlegroups.com.
To unsubscribe from this group, send email to
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/open-iscsi?hl=en.
Re: [PATCH 2/2] cxgbi: get rid of gl_skb in cxgbi_ddp_info
On 01/07/2011 06:09 PM, Karen Xie wrote:
Hi, Mike,
Yes, the message size is different between cxgb3i and cxgb4i. I am not
I am not sure if we are talking about the same thing. Mostly I am
confused a little :)
For pool I just mean gl_skb. So I mean cxgb3i could make its own pool
like it is now. Basically just move gl_skb to some cxgb3i struct and mv
ddp_alloc_gl_skb related code to cxgb3i.
Then cxgb4i could do something similar if possible. Below when I was
asking about variable sizes I meant that for cxgb4i it seemed harder
because ddp_set_map-ddp_ppod_write_idata-alloc_wr allocates the skb
based on wr_len.
using the pool mainly because this is on the tx side and tx skb
recycling does not seem to be utilized much.
What pool are you talking about? Some sort of skb pool from the network
layer?
Karen
-Original Message-
From: Mike Christie [mailto:micha...@cs.wisc.edu]
Sent: Friday, January 07, 2011 3:48 PM
To: open-iscsi@googlegroups.com
Cc: Karen Xie; linux-s...@vger.kernel.org;
james.bottom...@hansenpartnership.com
Subject: Re: [PATCH 2/2] cxgbi: get rid of gl_skb in cxgbi_ddp_info
On 01/07/2011 05:42 PM, Mike Christie wrote:
On 01/07/2011 04:45 PM, k...@chelsio.com wrote:
[PATCH 2/2] cxgbi: get rid of gl_skb in cxgbi_ddp_info.
From: Karen Xiek...@chelsio.com
Remove gl_skb from cxgbi_ddp_info as it is only used by cxgb3i.
Signed-off-by: Karen Xiek...@chelsio.com
---
drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 51
+---
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 2 -
drivers/scsi/cxgbi/libcxgbi.c | 15 +--
drivers/scsi/cxgbi/libcxgbi.h | 3 --
4 files changed, 8 insertions(+), 63 deletions(-)
diff --git a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
index a129a17..e2362b9 100644
--- a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
+++ b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
@@ -1108,10 +1108,11 @@ static int ddp_set_map(struct cxgbi_sock
*csk,
struct cxgbi_pagepod_hdr *hdr,
csk, idx, npods, gl);
for (i = 0; i npods; i++, idx++, pm_addr += PPOD_SIZE) {
- struct sk_buff *skb = ddp-gl_skb[idx];
+ struct sk_buff *skb = alloc_wr(sizeof(struct ulp_mem_io) +
+ PPOD_SIZE, 0, GFP_ATOMIC);
I think you want to try to avoid lots of little GFP_ATOMIC allocations
in the main IO path, because it probably is bad for performance and
because they can fail and you can be stuck with no mem but other
allocations needing to write data out.
Did you want to just make each driver allocate a pool/map, then
allocate
from that pool/map in these places (cxgb4i does a similar skb
allocation
at these points right?)?
Oh yeah, is the complication that the cxgb3i driver uses 1 size for the
objects but cxgb4i is variable?
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
You received this message because you are subscribed to the Google Groups
open-iscsi group.
To post to this group, send email to open-is...@googlegroups.com.
To unsubscribe from this group, send email to
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/open-iscsi?hl=en.
