Re: [PATCH 2/2] libiscsi: Annotate fall-through

[Chris Leech]

On Thu, Mar 01, 2018 at 10:07:48AM -0800, Bart Van Assche wrote:
> This patch avoids that building with W=1 causes the compiler to
> complain about fall-through.
> 
> Signed-off-by: Bart Van Assche 
> Cc: Lee Duncan 
> Cc: Chris Leech 
> ---
>  drivers/scsi/libiscsi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index b39bfdfec337..345533f80dae 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -1705,6 +1705,7 @@ int iscsi_queuecommand(struct Scsi_Host *host, struct 
> scsi_cmnd *sc)
>   sc->result = DID_NO_CONNECT << 16;
>   break;
>   }
> + /* fall through */
>   case ISCSI_STATE_IN_RECOVERY:
>   reason = FAILURE_SESSION_IN_RECOVERY;
>   sc->result = DID_IMM_RETRY << 16;
> -- 
> 2.16.2

Signed-off-by: Chris Leech 

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.

Re: [PATCH 2/2] libiscsi: Annotate fall-through

[Lee Duncan]

On 03/01/2018 10:07 AM, Bart Van Assche wrote:
> This patch avoids that building with W=1 causes the compiler to
> complain about fall-through.
> 
> Signed-off-by: Bart Van Assche 
> Cc: Lee Duncan 
> Cc: Chris Leech 
> ---
>  drivers/scsi/libiscsi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index b39bfdfec337..345533f80dae 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -1705,6 +1705,7 @@ int iscsi_queuecommand(struct Scsi_Host *host, struct 
> scsi_cmnd *sc)
>   sc->result = DID_NO_CONNECT << 16;
>   break;
>   }
> + /* fall through */
>   case ISCSI_STATE_IN_RECOVERY:
>   reason = FAILURE_SESSION_IN_RECOVERY;
>   sc->result = DID_IMM_RETRY << 16;
> 
Signed-off-by: Lee Duncan 
-- 
Lee Duncan

-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at https://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.