[VOTE RESULT] publish openjpa 0.9.5-incubating podling release

2006-10-19 Thread Marc Prud'hommeaux
OpenJPA People- The final tally of the vote is: +1 votes: 3 Bryan Noll: http://mail-archives.apache.org/mod_mbox/incubator-open- jpa-dev/200610.mbox/[EMAIL PROTECTED] Abe White: http://mail-archives.apache.org/mod_mbox/incubator-open- jpa-dev/200610.mbox/[EMAIL PROTECTED] Patrick

RE: svn commit: r465623 - in /incubator/openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype: ./ IdentityGenerationType.java TestGenerationType.java

2006-10-19 Thread Patrick Linskey
Also, I noticed that you have a tearDown() in your test case. Historically, we've typically not written tearDown() methods, and just put the tear-down logic in the beginning of setUp(). I understand the value of having a separate tearDown() to keep things clean, but it'd be good if you called

Re: [VOTE RESULT] publish openjpa 0.9.5-incubating podling release

2006-10-19 Thread Marc Prud'hommeaux
Eddie- On Oct 19, 2006, at 10:17 AM, Eddie O'Neil wrote: Marc-- A couple of comments: #1: Since the vote has only been open for 24 hours, there may not have been enough time for everyone to comment on the release -- while there are already 3 +1s which are sufficient to declare a release,

Re: [VOTE RESULT] publish openjpa 0.9.5-incubating podling release

2006-10-19 Thread robert burrell donkin
On 10/19/06, Marc Prud'hommeaux [EMAIL PROTECTED] wrote: Eddie- snip - Is there an SVN tag for this? No, although the SVN revision number is contained in the release (FTR, it can be seen by running: java org.apache.openjpa.conf.OpenJPAVersion). Is there a policy on SVN tag names for

Re: [VOTE RESULT] publish openjpa 0.9.5-incubating podling release

2006-10-19 Thread Eddie O'Neil
Marc-- Quick work! Thanks for taking care of these things. Couple of comments: I didn't realize there was a de-facto minimum time Typically, vote time runs for 3 days, which gives folks in different time zones and day jobs enough time to have a look. I did follow-up with a thread on