Re: svn commit: r465623 - in /incubator/openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype: ./ IdentityGenerationType.java TestGenerationType.java

2006-10-20 Thread Craig L Russell
Hi, I like to have both setUp and tearDown in my test cases. In another project, we created a mother of all test cases and defined a setUp and tearDown there that did some routine stuff that many test cases needed, such as removing persistent instances that would cause subsequent test

RE: svn commit: r465623 - in /incubator/openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype: ./ IdentityGenerationType.java TestGenerationType.java

2006-10-19 Thread Patrick Linskey
Also, I noticed that you have a tearDown() in your test case. Historically, we've typically not written tearDown() methods, and just put the tear-down logic in the beginning of setUp(). I understand the value of having a separate tearDown() to keep things clean, but it'd be good if you called