On Aug 30, 2006, at 8:56 AM, Eddie O'Neil wrote:
Kevin--
Wearing my mentor hat...
I say go for it -- if you're confident in your changes, it passes
the tests, and does right by the project, this is how community is
built. Occasionally, we'll break a few eggs, but this is how everyone
learns to work together.
I'm inclined to agree ... when patches wind up breaking our BEA-
internal tests, then that will only further encourage us to migrate
some more of those tests into the public OpenJPA code base in a
timely matter.
In this particular case, I had said I would test the patch, and never
got around to doing it, and then a conflicting change got committed
to the file by someone else that invalidated the patch file, leading
to wasted work. Sorry about that. We hope that my negligence and
laziness will be the exception rather than the rule going forward :)
Patrick, Abe, and others can certainly (and likely will!) chime in
and provide feedback on the patch or process for testing, but your
role as a committer means that the community trusts you to commit
code.
Cheers,
Eddie
On 8/30/06, Kevin Sutter [EMAIL PROTECTED] wrote:
Bill,
Absolutely, I am a committer. But, I am still learning the whole
code
base. It's quite large... :-) So, I was still looking for some BEA
assistance with verifying the patches before committing the
changes. But,
like this thread is indicating, maybe I just need to verify the
patch to the
best of my ability and go for it. Problems will get resolved one
way or the
other...
I'll wait for some feedback from other participants before going that
route... :-)
Kevin
On 8/30/06, Bill Dudney [EMAIL PROTECTED] wrote:
Just reading over the OpenJPA-15 thread and now I understand this
thread much better.
Kevin, aren't you a committer? If so why not take the patch and
apply
it, if it works for you and passes the current test suite then it
should probably be committed.
If you want a second opinion I'd be glad to try out the patch this
afternoon.
TTFN,
-bd-
On Aug 30, 2006, at 8:58 AM, Bill Dudney wrote:
Hi Kevin,
Should have known BAU - ah well, can't keep all that in my
head...
I hope and expect that patches won't be left in JIRA
unresolved or
unapplied for long periods of time. That would be a major bummer,
esp for the poor folk trying to help!
Yes forcing the hand would be a good thing IMO :-)
TTFN,
-bd-
On Aug 30, 2006, at 8:52 AM, Kevin Sutter wrote:
Bill,
BAU == Business As Usual
I guess verifying the patch against the existing set of tests
would be one
way to do it. But, knowing that there are other internal tests
that might
be affected seemed a little harsh. So, I was trying to be more
diplomatic.
I guess it would force the hand to deliver the failing
tests... :-)
Kevin
On 8/30/06, Bill Dudney [EMAIL PROTECTED] wrote:
Hi Kevin,
I like the idea of raising awareness of available patches but I
don't
think we want to hold someone up that is doing a bunch of
work with
having to verify all patches that have been submitted and
how the
patches might effect the new work.
One way (I think) to address the concern is to have more
than one of
us apply the patch, run the tests and verify that all tests
pass.
Assuming all tests pass then the patch should be OK and we
put a
comment into the JIRA to that effect. Only problem I can see
is that
some of the internal BEA tests would fail but these tests
are on
their way into the OpenJPA code base correct?
BTW - BAU == ?
TTFN,
-bd-
On Aug 30, 2006, at 8:07 AM, Kevin Sutter wrote:
Hi,
I'm looking to start a conversation on how we can coordinate
timely
verification of patch submissions. As you have probably
noticed,
Catalina
and I have been working on a patch for OPENJPA-15 (
http://issues.apache.org/jira/browse/OPENJPA-15).
Granted, we
have
had a
couple of miscues as we continue to learn the patching and
contribution
processes. But, we have also had to regenerate the patch
a few
times
because of changes being integrated into the affected
files before
the patch
could be verified.
I'm wondering if this is BAU in the open-source community, or
is there
something we can do to help this process?
I know there was a discussion about having the ability to
flag a
JIRA report
when a patch is attached. I don't believe I've seen
resolution of
that
request. Flagging a JIRA report might help some, but it
still
doesn't help
with a timely verification of the patch. At least it would
raise the
awareness that patches are available for verification.
And, any
new change
activities should check for possible patches before
hitting the
commit
button.
Since this OpenJPA community is still highly reliant on the
original authors
of the contribution,
