[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473537
]
Patrick Linskey commented on OPENJPA-141:
-
> That's because I ran up against the other OpenJPA convention of
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473527
]
Craig Russell commented on OPENJPA-141:
---
>Just posted another version of the performance patch for openjpa-141
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473521
]
Kevin Sutter commented on OPENJPA-141:
--
> Looks good to me. Super-tiny nit: you've got a brace on a newline in
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473515
]
Patrick Linskey commented on OPENJPA-141:
-
Looks good to me. Super-tiny nit: you've got a brace on a newline
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473445
]
Kevin Sutter commented on OPENJPA-141:
--
Getting close to another patch posting...
>> The two-way check in Fetc
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473416
]
Abe White commented on OPENJPA-141:
---
> The two-way check in FetchConfigurationImpl was overlooked. Thank you. But,
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473290
]
Patrick Linskey commented on OPENJPA-141:
-
> This is also affected by whether we use a giant cache (includin
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473285
]
Craig Russell commented on OPENJPA-141:
---
>> If we want a "hard cache that drops entries for classes that are
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473254
]
Patrick Linskey commented on OPENJPA-141:
-
> If we want a "hard cache that drops entries for classes that ar
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473253
]
Patrick Linskey commented on OPENJPA-141:
-
> > 4. Why are you using a static JNDI location -> TM cache in
>
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473243
]
Kevin Sutter commented on OPENJPA-141:
--
Yes, good catch, Craig. The original location that I wanted to resolve
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473234
]
Abe White commented on OPENJPA-141:
---
Craig, good catch. I didn't even look at the actual assignable method code..
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473231
]
Craig Russell commented on OPENJPA-141:
---
1. The original functionality of isAssignable(Class a, Class b) is to
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473228
]
Kevin Sutter commented on OPENJPA-141:
--
Good thing I posted the patch... ;-)
>1. Why not keep a single assign
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473172
]
Abe White commented on OPENJPA-141:
---
1. Why not keep a single assignable types map in ImplHelper?
2. I thought we
Hi Kevin,
On Feb 13, 2007, at 11:25 AM, Kevin Sutter (JIRA) wrote:
Kevin Sutter commented on OPENJPA-141:
--
Personally, I think I provide sufficient due diligence on the
Issues that I own to stick with the normal "commit then review"
approach. There ar
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472840
]
Kevin Sutter commented on OPENJPA-141:
--
Personally, I think I provide sufficient due diligence on the Issues th
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472829
]
Craig Russell commented on OPENJPA-141:
---
Given the number of iterations already documented on this issue, woul
Exactly.
On 2/13/07, Patrick Linskey (JIRA) <[EMAIL PROTECTED]> wrote:
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472813]
Patrick Linskey commented on OPENJPA-141:
-
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472813
]
Patrick Linskey commented on OPENJPA-141:
-
> Please attach an svn patch to this JIRA when it's ready. I'd li
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472795
]
Craig Russell commented on OPENJPA-141:
---
Nice work, Kevin and Abe.
Just a reminder. Please attach an svn patc
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472790
]
Kevin Sutter commented on OPENJPA-141:
--
Sounds good, Abe. Thanks for the comments, Abe and Craig. Here's the
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472758
]
Abe White commented on OPENJPA-141:
---
Craig:
There doesn't appear to be any hashCode/equals performance issues. As
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472674
]
Kevin Sutter commented on OPENJPA-141:
--
> No, the current code holds the Classes with hard refs, and maps them
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472516
]
Kevin Sutter commented on OPENJPA-141:
--
> So what might work is having the keys be weak, and the otherwise unre
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472510
]
Craig Russell commented on OPENJPA-141:
---
>> Craig thinks: Weak references are supposed to be cleaned up if the
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472506
]
Abe White commented on OPENJPA-141:
---
> Craig thinks: Weak references are supposed to be cleaned up if the referenc
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472478
]
Craig Russell commented on OPENJPA-141:
---
Abe opined:
1. Each BrokerFactory has a ManagedRuntime. You can have
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472455
]
Abe White commented on OPENJPA-141:
---
1. Each BrokerFactory has a ManagedRuntime. You can have multiple
BrokerFac
[
https://issues.apache.org/jira/browse/OPENJPA-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472440
]
Kevin Sutter commented on OPENJPA-141:
--
Re: Caching the TransactionManager in a static...
Although we could c
30 matches
Mail list logo
