Re: svn commit: r525252 - in /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql: AbstractDB2Dictionary.java DB2Dictionary.java

2007-04-04 Thread Abe White
> ... for certain values of "our". I think that it's important that we > discuss API decisions as a group, as they have significant impacts on > the OpenJPA product moving forward. This is especially important when > there are dissenting views on a particular API decision, as is the > case > here

Re: svn commit: r525252 - in /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql: AbstractDB2Dictionary.java DB2Dictionary.java

2007-04-03 Thread David Wisneski
sday, April 03, 2007 1:24 PM > To: open-jpa-dev@incubator.apache.org > Subject: Re: svn commit: r525252 - in > /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache > /openjpa/jdbc/sql: AbstractDB2Dictionary.java DB2Dictionary.java > > SQL provides capabilities for tuning of

RE: svn commit: r525252 - in /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql: AbstractDB2Dictionary.java DB2Dictionary.java

2007-04-03 Thread Patrick Linskey
Message- > From: David Wisneski [mailto:[EMAIL PROTECTED] > Sent: Tuesday, April 03, 2007 1:24 PM > To: open-jpa-dev@incubator.apache.org > Subject: Re: svn commit: r525252 - in > /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache > /openjpa/jdbc/sql: AbstractDB2Diction

Re: svn commit: r525252 - in /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql: AbstractDB2Dictionary.java DB2Dictionary.java

2007-04-03 Thread David Wisneski
SQL provides capabilities for tuning of locking. In the case of DB2 this involves setting the isolation level, update lock, result set optimize set, etc. JPA spec does not provide support for these concepts but does provide a rather open ended setHint api. It is our intent to make use this api s

Re: svn commit: r525252 - in /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql: AbstractDB2Dictionary.java DB2Dictionary.java

2007-04-03 Thread Craig L Russell
Never mind. I fixed it. I guess we still need to decide whether the change goes in, but meantime it should compile... Craig On Apr 3, 2007, at 12:58 PM, Ritika Maheshwari wrote: yes will do that ritika On 4/3/07, Craig L Russell <[EMAIL PROTECTED]> wrote: Hi David, The DB2Dictionary cl

Re: svn commit: r525252 - in /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql: AbstractDB2Dictionary.java DB2Dictionary.java

2007-04-03 Thread Ritika Maheshwari
yes will do that ritika On 4/3/07, Craig L Russell <[EMAIL PROTECTED]> wrote: Hi David, The DB2Dictionary class doesn't compile with 1.4 due to autoboxing. Can you please fix this? Craig public String getForUpdateClause(JDBCFetchConfiguration fetch, boolean forUpdate) { String

Re: svn commit: r525252 - in /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql: AbstractDB2Dictionary.java DB2Dictionary.java

2007-04-03 Thread Abe White
> The DB2Dictionary class doesn't compile with 1.4 due to autoboxing. > Can you please fix this? And I'd like to see all those hints defined as static constants on the dictionary class and named for DB2 (if they're that specific) and capitalized while you're at it -- see OracleDictionary.SEL

RE: svn commit: r525252 - in /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql: AbstractDB2Dictionary.java DB2Dictionary.java

2007-04-03 Thread Patrick Linskey
I'm a little nervous about this change still. I don't like it that we're adding yet another way to configure locking, especially since it seems like the lock level settings should be sufficient (or nearly so) to handle per-transaction / per-query lock levels. I also still do not believe that isola

Re: svn commit: r525252 - in /incubator/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/sql: AbstractDB2Dictionary.java DB2Dictionary.java

2007-04-03 Thread Craig L Russell
Hi David, The DB2Dictionary class doesn't compile with 1.4 due to autoboxing. Can you please fix this? Craig public String getForUpdateClause(JDBCFetchConfiguration fetch, boolean forUpdate) { String isolationLevel = null; Boolean updateClause = null; DatabaseM