Re: missing getAll(List keys) method?

2007-05-31 Thread Daniel Lee
I can come up with a sample implementation and provide the result comparison of the performance measurement. Daniel On 5/30/07, Marc Prud'hommeaux [EMAIL PROTECTED] wrote: I personally think it sounds like a good idea that has a lot of potential for performance improvement. Perhaps someone

Re: missing getAll(List keys) method?

2007-05-30 Thread Kevin Sutter
Marc, What are your views on this request? Since you seem to be intimately familiar with the data cache API, do you see a problem with introducing this additional get method? Either from an expectation viewpoint or an implementation viewpoint? Thanks. Kevin On 5/29/07, Daniel Lee [EMAIL

Re: missing getAll(List keys) method?

2007-05-30 Thread Marc Prud'hommeaux
I personally think it sounds like a good idea that has a lot of potential for performance improvement. Perhaps someone could come up with a sample implementation that adds the API and a default implementation in the DataCacheImpl and compare the performance in the scenario mentioned below?

Re: missing getAll(List keys) method?

2007-05-29 Thread Daniel Lee
Hi Craig, The discussed API (getAll) is for fetching objects that's already cached in the DataCache. From what I understand, OpenJPA executes the following code when loading (find()) a customer which exists in the DataCache. It loads not only the customer but also the objects in any eager

Re: missing getAll(List keys) method?

2007-05-24 Thread Daniel Lee
Hi Craig, I think findAll() is different. It is a client level API and the getAll() here is for internal fetch from data cache. In the example, when an application issue findAll() for a list of customers. It internally, for each customer with order(s), loads the eager relationship (orders)

Re: missing getAll(List keys) method?

2007-05-24 Thread Craig L Russell
Hi Daniel, On May 24, 2007, at 11:59 AM, Daniel Lee wrote: Hi Craig, I think findAll() is different. It is a client level API and the getAll() here is for internal fetch from data cache. In the example, when an application issue findAll() for a list of customers. It internally, for each