Re: [Open-scap] Implementation for an AppArmor probe.

2017-09-15 Thread Bruno Ducrot
Hi Jan, On Fri, Sep 15, 2017 at 07:23:31AM -0400, Jan Cerny wrote: > Hi, > > I have reviewed your patch. I have tested it on my Ubuntu Server 16.04.3, > and it works great. > > The patch overall looks good, but I have a few minor findings: > > src/OVAL/probes/unix/linux/apparmorstatus.c : > *

Re: [Open-scap] Implementation for an AppArmor probe.

2017-09-15 Thread Jan Cerny
Hi, I have reviewed your patch. I have tested it on my Ubuntu Server 16.04.3, and it works great. The patch overall looks good, but I have a few minor findings: src/OVAL/probes/unix/linux/apparmorstatus.c : * It shouldn't fail hard if you don't run it as root. In general OpenSCAP doesn't term

Re: [Open-scap] Implementation for an AppArmor probe.

2017-09-15 Thread Jan Cerny
Hi, The new patch looks great. I'll review and test. I'll let you know. Thanks Regards Jan Černý Security Technologies | Red Hat, Inc. - Original Message - > From: "Bruno Ducrot" > To: "Jan Cerny" > Cc: open-scap-list@redhat.com, "William Munyan" > > Sent: Monday, September 11, 201