Re: [Open64-devel] Code Review request for fix bug962[CG]

2012-05-04 Thread Jian-Xin Lai
It's better to move the comments out of the expression and refine the comments for the whole if-condition. 2012/5/4 Gang Yu > Hi, > > could a gatekeeper please help review the fix bug962( > https://bugs.open64.net/show_bug.cgi?id=962)? > > A cut-down case below: > > a sample case: > > unsigned l

[Open64-devel] Code Review request for fix bug962[CG]

2012-05-03 Thread Gang Yu
Hi, could a gatekeeper please help review the fix bug962( https://bugs.open64.net/show_bug.cgi?id=962)? A cut-down case below: a sample case: unsigned long copy_user_generic_string(void *to, const void *from, unsigned len); unsigned long copy_user_generic_unrolled(void *to, const void *from, un