Re: [Open64-devel] code review for VCG support patch [CG]

2011-08-08 Thread Jian-Xin Lai
Looks fine to me. 2011/8/8 Wu Yongchong > Hi, > I have remove VENDOR_OSP macro, here is the new patch > > > On Fri, Aug 5, 2011 at 10:43 AM, Jian-Xin Lai wrote: > > I don't think the "#if defined(VENDOR_OSP)" is needed for these kinds of > > changes. Could you please remove them? > > > > 2011/7

Re: [Open64-devel] code review for VCG support patch [CG]

2011-08-08 Thread Wu Yongchong
Hi, I have remove VENDOR_OSP macro, here is the new patch On Fri, Aug 5, 2011 at 10:43 AM, Jian-Xin Lai wrote: > I don't think the "#if defined(VENDOR_OSP)" is needed for these kinds of > changes. Could you please remove them? > > 2011/7/26 Wu Yongchong >> >> Hi, all >> Can a gatekeeper help re

Re: [Open64-devel] code review for VCG support patch [CG]

2011-08-04 Thread Jian-Xin Lai
I don't think the "#if defined(VENDOR_OSP)" is needed for these kinds of changes. Could you please remove them? 2011/7/26 Wu Yongchong > Hi, all > Can a gatekeeper help review this patch > > This patch adds support to print VCG graphs for procedure CFGs, at > various points in CG. > > Specifical

[Open64-devel] code review for VCG support patch [CG]

2011-07-26 Thread Wu Yongchong
Hi, all Can a gatekeeper help review this patch This patch adds support to print VCG graphs for procedure CFGs, at various points in CG. Specifically, the 'V' character can be used (to create VCG graphs) wherever the 'r' character is used to print the CG IR. Examples: -Wb,-tVa - create a VCG grap