Re: [Open64-devel] code review for bug 520

2011-02-13 Thread Sun Chan
ok. Please go ahead with the checkin Sun On Mon, Feb 14, 2011 at 11:30 AM, Jian-Xin Lai wrote: > If the value is 4, all functions will be instrumented. This may cause > the extern inline functions in header files are emitted as strong symbols > into the generated .s file. There will be 'duplicate

Re: [Open64-devel] code review for bug 520

2011-02-13 Thread Jian-Xin Lai
If the value is 4, all functions will be instrumented. This may cause the extern inline functions in header files are emitted as strong symbols into the generated .s file. There will be 'duplicated symbols' in the final linking phase. The code in wn_cgy_instrument.cxx is: // The -OPT:cyg_instr fla

Re: [Open64-devel] code review for bug 520

2011-02-12 Thread Sun Chan
what is the diff between 3 and 4? Sun On Sat, Feb 12, 2011 at 4:33 PM, Jian-Xin Lai wrote: > Hi, > > Bug 520 is reported and fixed by Ron Lieberman. > https://bugs.open64.net/show_bug.cgi?id=520 > Here comes his patch: > Index: osprey/driver/OPTIONS > =

[Open64-devel] code review for bug 520

2011-02-12 Thread Jian-Xin Lai
Hi, Bug 520 is reported and fixed by Ron Lieberman. https://bugs.open64.net/show_bug.cgi?id=520 Here comes his patch: Index: osprey/driver/OPTIONS === --- osprey/driver/OPTIONS (revision 3475) +++ osprey/driver/OPTIONS (wo